Fixed #532 - Implemented onlyQuoteStrings

[boldt]

This is a fix for #532

[pokoli]

Thanks for your contribution.

The review looks good, I leaved a comment which will improve the current code. It will be great if you can fix it also.

Could you please document the new option in the parse section of our docs. See:
https://github.com/mholt/PapaParse/blob/master/docs/docs.html#L225

[pokoli]

I think we should rename str into value here to make code clearer.

[boldt]

• I renamed str into value
• I added a documentation for the new property
• I also formatted the unparse config as an unordered list
  • Maybe it makes sense, to format the unparse options the same style as the parse options? I would handle it (in a separate PR).

[pokoli]

After reading the docs I'm wondering if we should not allow three options on the quotes parameters:

• false
• true
• 'only-strings'

With a second though I'm wondering if we should allow to pass a function to the quotes argument which will accept the value and the col and return true if the field needs quoting. This will prevent adding more settings like: 'only-numbers' and give the full power to the end user. For the string use case it will be:

config: {
'quotes': function(value, col) { return typeof value == 'string' },
}

What do you think?

[boldt]

I think, adding a function is a quite nice idea! This makes it much more flexible.

I would like to keep the true/false to be backward compatible, thus upgrading to a newer version does not break existing applications (e.g., true/false will be internally implemented as a function as well), thus:

• false - do not add quotes (default)

'quotes': function(value, col) { return false; }

• true - add quotes

'quotes': function(value, col) { return false; }

• a function is provided - use the function (like your example)

If you go for it, I would handle the implementation for this as well.

[pokoli]

Your proposal makes sense for me. Please go for the implementation!

[MonkeyDZeke]

@boldt Are you still planning on implementing the function option? I can help out if you want.

[closet6]

@boldt Are you still planning on implementing the function option? I can help out if you want.

Much needed feature for our team if you're looking for any motivation. ;-)