Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented quotes config optionally as function #703

Merged
merged 5 commits into from Aug 29, 2019

Conversation

Puzzleton
Copy link
Contributor

Fix for issue #532. In the thread for #534, it was suggested that the quotes parameter be implemented as a function.

Copy link
Collaborator

@pokoli pokoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your proposal, I've added two comments on the review could you please fix them before I can merge it?

tests/test-cases.js Outdated Show resolved Hide resolved
docs/docs.html Outdated Show resolved Hide resolved
@pokoli pokoli merged commit 80a1044 into mholt:master Aug 29, 2019
@pokoli
Copy link
Collaborator

pokoli commented Aug 29, 2019

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants