Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metanorma/metanorma#202 add socksify dependency and support SOCKS_PROXY env var #247

Merged
merged 2 commits into from Jul 17, 2021
Merged

metanorma/metanorma#202 add socksify dependency and support SOCKS_PROXY env var #247

merged 2 commits into from Jul 17, 2021

Conversation

CAMOBAP
Copy link
Contributor

@CAMOBAP CAMOBAP commented Jul 15, 2021 •
edited

Open questions

  • Should we handle a case git repos which were cloned with proxy and then metanorma executed without proxy? Maybe should we leave it up to the user at all to configure with --global git params https://gist.github.com/evantoli/f8c23a37eb3558ab8765
    • End-user will be responsible to modify ~/.gitconfig to setup proxy

Related PRs:

Related other gems issues/PRs:

@CAMOBAP CAMOBAP self-assigned this Jul 15, 2021
@CAMOBAP CAMOBAP force-pushed the feature/socks-proxy-support branch from 71c7215 to 211f4f4 Compare July 15, 2021 15:05
@CAMOBAP CAMOBAP mentioned this pull request Jul 15, 2021
Closed
@CAMOBAP CAMOBAP force-pushed the feature/socks-proxy-support branch from 211f4f4 to 037c87c Compare July 16, 2021 10:17
@CAMOBAP CAMOBAP marked this pull request as ready for review July 16, 2021 11:36
@ronaldtse
Copy link
Contributor

Thank you @CAMOBAP ! Can you also add documentation to the README and to metanorma.org on how to use Metanorma with HTTP/HTTPS/SOCKS proxy?

@ronaldtse ronaldtse merged commit 679eaa1 into main Jul 17, 2021
This was referenced Jul 17, 2021
Closed
Closed
@ronaldtse ronaldtse deleted the feature/socks-proxy-support branch July 17, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldtse ronaldtse Awaiting requested review from ronaldtse

@abunashir abunashir Awaiting requested review from abunashir

@opoudjis opoudjis Awaiting requested review from opoudjis

Assignees

@CAMOBAP CAMOBAP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CAMOBAP @ronaldtse