Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metanorma/metanorma#202 respect HTTP[S]|SOCKS_PROXY env vars during git clone #250

Closed
wants to merge 1 commit into from

Conversation

CAMOBAP
Copy link
Contributor

@CAMOBAP CAMOBAP commented Jul 15, 2021

Open questions

  • Should we handle a case git repos which were cloned with proxy and then metanorma executed without proxy?

Related PRs:

@CAMOBAP CAMOBAP self-assigned this Jul 15, 2021
@CAMOBAP CAMOBAP force-pushed the feature/add-support-for-proxies branch from 0913c7d to 4655d16 Compare July 15, 2021 15:36
@alexeymorozov
Copy link
Contributor

Looks good to me 🔥

@ronaldtse
Copy link
Contributor

Should we handle a case git repos which were cloned with proxy and then metanorma executed without proxy?

For simplicity reasons let’s not support the “per git repo proxy” case. Thanks!!

@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Jul 16, 2021

For simplicity reasons let’s not support the “per git repo proxy” case. Thanks!!

Great, users still will be able to do clone by providing a proxy in global ~/.gitconfig. I will write about it in blog post

Also, we have two big pros for this approach:

  • ruby-git gem doesn't support default_branch API right now, I just hardcoded 'master' but this may not work for all repos, I have prepared PR for ruby-git
  • ruby-git don't support depth for git fetch which passed by fontist this also may create some difficulties

Just to make sure that we are on the same page, I'm going to close this without merge, @ronaldtse @alexeymorozov any objections?

@CAMOBAP CAMOBAP closed this Jul 16, 2021
@maxirmx maxirmx deleted the feature/add-support-for-proxies branch July 26, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants