Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed #347 - added _ to the list of valid hostname characters #349

Closed
wants to merge 1 commit into from
Closed

fixed #347 - added _ to the list of valid hostname characters #349

wants to merge 1 commit into from

Conversation

vzaidman
Copy link
Contributor

@vzaidman vzaidman commented Aug 9, 2017

No description provided.

@vzaidman vzaidman mentioned this pull request Aug 9, 2017
Closed
@rodneyrehm
Copy link
Member

thank you! two small things:

  • please add an example URL containing a _ to test/urls.js to make sure this doesn't break in the future
  • please target the master branch not gh-pages

@vzaidman
Copy link
Contributor Author

vzaidman commented Aug 9, 2017

wrong branch.
#348 is the correct PR

@vzaidman vzaidman closed this Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vzaidman @rodneyrehm