can't parse a domain with underscore

[vzaidman]

probably because of this code

  // allowed hostname characters according to RFC 3986
  // ALPHA DIGIT "-" "." "_" "~" "!" "$" "&" "'" "(" ")" "*" "+" "," ";" "=" %encoded
  // I've never seen a (non-IDN) hostname other than: ALPHA DIGIT . -
  URI.invalid_hostname_characters = /[^a-zA-Z0-9\.-]/;

[rodneyrehm]

Do you want to send a PR for that? (maybe also adding an URL with a _ in its domain to urls.js for testing)

[vzaidman]

sure ill send a pr

[vzaidman]

submitted a PR with a relevant test:
#348

[vzaidman]

@rodneyrehm is there a possibility to have

host:name.something.com

?

[rodneyrehm]

the hostname could be an IPv6 address and that may contain :. A domain name may not - as far as I know - but then, I wasn't aware _ was legal either…

[vzaidman]

host:name.something.com currently fails in tests because name.something.com is considered the port
so the hostname i test is now:

    var u = new URI('http://some.complex_host-name123.org/');

[rodneyrehm]

When you opened the PR I thought I'd immediately close the issue because _ is not legal in domain names per RFC 1034. However, the URL spec seems to permit it and Chrome's implementation parses it. That said, : is considered an illegal code point

[vzaidman]

gotcha. so the PR can be merged i think.

[rodneyrehm]

fixed in v1.18.12