Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ts-node to 10.8.2 #16897

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Bump ts-node to 10.8.2 #16897

merged 1 commit into from
Jul 11, 2022

Conversation

bershanskiy
Copy link
Contributor

@bershanskiy bershanskiy commented Jul 10, 2022

Summary

This is a follow-up to #16669. That PR switched BCD to a custom fork of ts-node which integrated a specific patch for a bug fix in NodeJS 16.15. Now, ts-node 10.8.2 was released and it integrates this fix upstream, so BCD can switch back.

Test results and supporting details

I produced this patch by:

  1. editing package.json to replace "ts-node": "github:queengooborg/ts-node#patch-1-built", with "ts-node": "~10.8.2",
  2. running npm i ts-node@~10.8.2 to update package-lock.json

@queengooborg It might be easier for you to follow the above steps and to produce this patch by yourself in the first place than to verify correctness of "integrity" fields. In that case, please do what is easiest to verify and e.g., close this PR and open a different one.

Test: The CI passed when I ran it on NodeJS 16 here: https://github.com/bershanskiy/browser-compat-data/runs/7271084934

Related issues

#16669
#16668

@github-actions github-actions bot added dependencies ⛓️ Pull requests that update a dependency package or file. infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project labels Jul 10, 2022
@queengooborg
Copy link
Collaborator

Can confirm 10.8.2 includes the patch -- thanks for following up on this!

@queengooborg queengooborg merged commit 845e0e9 into mdn:main Jul 11, 2022
@bershanskiy bershanskiy deleted the ts-node branch July 11, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ⛓️ Pull requests that update a dependency package or file. infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants