Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next steps with TypeScript #16668

Closed
bershanskiy opened this issue Jun 14, 2022 · 2 comments
Closed

Next steps with TypeScript #16668

bershanskiy opened this issue Jun 14, 2022 · 2 comments
Labels
infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project

Comments

@bershanskiy
Copy link
Contributor

bershanskiy commented Jun 14, 2022

As of 23 Jun:


Old list for reference:

Known bugs:

Future improvements:

  • Stricter TSconfig options TSConfig: noFallthroughCasesInSwitch, allowUnreachableCode #16667
    • From my experience, it's better to have two different configs: one for development and one for CI/prod. For example, noImplicitAny can improve type coverage, but it is tough to program with it enabled. Similarly, allowUnreachableCode prevents dead code, but it is also inconvenient during rapid prototyping.
    • Go through use of any and introduce better types where appropriate (I have a few in mind)
@queengooborg queengooborg added the infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project label Jun 14, 2022
@queengooborg
Copy link
Collaborator

I've merged #16669 to mitigate the NodeJS v16 issue while we wait for upstream to merge and release the fix!

@bershanskiy
Copy link
Contributor Author

Closing this, since all relevant tasks were completed or abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project
Projects
None yet
Development

No branches or pull requests

2 participants