Add error handler to zipfile object #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems reasonable but since this module is not my area of expertise (I'm here to merge and deploy security fixes), I would like at least one other person to review this. |
|
It is great to see this merged! I probably no longer need this line of code |
This was referenced Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@malept
This PR adds the error handler to zipfile object before
zipfile.readEntrycalled.The reason is It causes unhandled exception when extract broken zip (ex. Central Directory Entry has been broken).
events.js:137 throw er; // Unhandled 'error' event ^ Error: invalid central directory file header signature: 0x2014b00 at /Users/matsuo/develop/projects/extract-zip/node_modules/yauzl/index.js:231:70 at /Users/matsuo/develop/projects/extract-zip/node_modules/yauzl/index.js:473:5 at /Users/matsuo/develop/projects/extract-zip/node_modules/fd-slicer/index.js:32:7 at FSReqWrap.wrapper [as oncomplete] (fs.js:676:17)Currently, I use the forked library into my product, but more better is to apply this patch.
Best regards!