Unhandled error event #65
Comments
|
It looks like it should already be handled by #63 |
aileen
added a commit
to aileen/gscan
that referenced
this issue
May 11, 2018
closes TryGhost#106 GScan didn't handle errors `.zip` file errors fully. Furthermore, there is a bug in one of the underlying dependencies, which does not handle and return an error event correctly. Until max-mapper/extract-zip#65 is fixed, we therefore need to use the forked version, which includes the fix here: https://github.com/AileenCGN/extract-zip.git
aileen
added a commit
to aileen/gscan
that referenced
this issue
May 11, 2018
closes TryGhost#106 GScan didn't handle errors `.zip` file errors fully. Furthermore, there is a bug in one of the underlying dependencies, which does not handle and return an error event correctly. Until max-mapper/extract-zip#65 is fixed, we therefore need to use the forked version, which includes the fix here: https://github.com/AileenCGN/extract-zip.git
aileen
added a commit
to aileen/gscan
that referenced
this issue
May 11, 2018
closes TryGhost#106 GScan didn't handle errors `.zip` file errors fully. Furthermore, there is a bug in one of the underlying dependencies, which does not handle and return an error event correctly. Until max-mapper/extract-zip#65 is fixed, we therefore need to use the forked version, which includes the fix here: https://github.com/AileenCGN/extract-zip.git
aileen
added a commit
to TryGhost/gscan
that referenced
this issue
May 15, 2018
closes #106 GScan didn't handle errors `.zip` file errors fully. Furthermore, there is a bug in one of the underlying dependencies, which does not handle and return an error event correctly. Until max-mapper/extract-zip#65 is fixed, we therefore need to use the forked version, which includes the fix here: https://github.com/AileenCGN/extract-zip.git
aileen
added a commit
to aileen/Ghost
that referenced
this issue
May 16, 2018
no issue - fixes a bug, that didn't catch errors caused by corrupt zip files - uses a fork of the `extract-zip` dependency with a bug fix for max-mapper/extract-zip#65
aileen
added a commit
to TryGhost/Ghost
that referenced
this issue
May 16, 2018
no issue - fixes a bug, that didn't catch errors caused by corrupt zip files - uses a fork of the `extract-zip` dependency with a bug fix for max-mapper/extract-zip#65
ololoken
pushed a commit
to ololoken/Ghost
that referenced
this issue
May 16, 2018
no issue - fixes a bug, that didn't catch errors caused by corrupt zip files - uses a fork of the `extract-zip` dependency with a bug fix for max-mapper/extract-zip#65
|
@maxogden Just wondering how likely it is to get this issue resolved? 😊 |
aileen
referenced
this issue
in TryGhost/extract-zip
Jan 3, 2019
|
Fixed in #67. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In case of a bad archive, for example
https://search.maven.org/remotecontent?filepath=org/xhtmlrenderer/flying-saucer-pdf-itext5/9.1.12/flying-saucer-pdf-itext5-9.1.12-sources.jar, yauzl library emits an error event which isn't handled. It causes a running process to crash instead of returning an error callback.Something like the following should be added in index.js:
The text was updated successfully, but these errors were encountered: