Add error handler to zipfile object (#67)

max-mapper · Mar 25, 2020 · 990fc64 · 990fc64
1 parent 8285111
commit 990fc64
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -32,6 +32,12 @@ module.exports = function (zipPath, opts, cb) {
 
       var cancelled = false
 
+      zipfile.on('error', function (err) {
+        if (err) {
+          cancelled = true
+          return cb(err)
+        }
+      })
       zipfile.readEntry()
 
       zipfile.on('close', function () {

diff --git a/test/broken.zip b/test/broken.zip
diff --git a/test/test.js b/test/test.js
@@ -11,6 +11,7 @@ var githubZip = path.join(__dirname, 'github.zip')
 var subdirZip = path.join(__dirname, 'file-in-subdir-without-subdir-entry.zip')
 var symlinkDestZip = path.join(__dirname, 'symlink-dest.zip')
 var symlinkZip = path.join(__dirname, 'symlink.zip')
+var brokenZip = path.join(__dirname, 'broken.zip')
 
 var relativeTarget = './cats'
 
@@ -193,3 +194,13 @@ test('files in subdirs where the subdir does not have its own entry is extracted
     })
   })
 })
+
+test('extract broken zip', function (t) {
+  t.plan(2)
+
+  mkdtemp(t, 'broken-zip', function (dirPath) {
+    extract(brokenZip, {dir: dirPath}, function (err) {
+      t.ok(err, 'Error: invalid central directory file header signature: 0x2014b00')
+    })
+  })
+})