Skip to content

Remove code smell assertion identified by Sonar #9424

Remove code smell assertion identified by Sonar

Remove code smell assertion identified by Sonar #9424

Triggered via pull request May 17, 2024 18:17
Status Success
Total duration 21m 7s
Artifacts 9

end-to-end-tests.yaml

on: pull_request
Build Element-Web
2m 34s
Build Element-Web
Matrix: playwright
end-to-end-tests
0s
end-to-end-tests
Fit to window
Zoom out
Zoom in

Annotations

4 errors, 37 warnings, and 8 notices
[Legacy Crypto] › timeline/timeline.spec.ts:926:13 › Timeline › message sending › should display a reply chain: matrix-react-sdk/playwright/e2e/timeline/timeline.spec.ts#L1033
1) [Legacy Crypto] › timeline/timeline.spec.ts:926:13 › Timeline › message sending › should display a reply chain Error: Screenshot comparison failed: 103 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/matrix-react-sdk/matrix-react-sdk/matrix-react-sdk/playwright/snapshots/timeline/timeline.spec.ts/event-tile-reply-chains-bubble-layout-linux.png Received: /home/runner/work/matrix-react-sdk/matrix-react-sdk/matrix-react-sdk/playwright/test-results/timeline-timeline-Timeline-801c1-hould-display-a-reply-chain-Legacy-Crypto/event-tile-reply-chains-bubble-layout-actual.png Diff: /home/runner/work/matrix-react-sdk/matrix-react-sdk/matrix-react-sdk/playwright/test-results/timeline-timeline-Timeline-801c1-hould-display-a-reply-chain-Legacy-Crypto/event-tile-reply-chains-bubble-layout-diff.png Call log: - expect.toHaveScreenshot(event-tile-reply-chains-bubble-layout.png) with timeout 5000ms - verifying given screenshot expectation - waiting for locator('.mx_EventTile_last') - locator resolved to <li tabindex="-1" aria-live="off" data-self="true" a…>…</li> - taking element screenshot - disabled all CSS animations - waiting for fonts to load... - fonts loaded - attempting scroll into view action - waiting for element to be stable - 103 pixels (ratio 0.01 of all image pixels) are different. - waiting 100ms before taking screenshot - waiting for locator('.mx_EventTile_last') - locator resolved to <li tabindex="-1" aria-live="off" data-self="true" a…>…</li> - taking element screenshot - disabled all CSS animations - waiting for fonts to load... - fonts loaded - attempting scroll into view action - waiting for element to be stable - captured a stable screenshot - 103 pixels (ratio 0.01 of all image pixels) are different. 1031 | 1032 | // Take a snapshot on bubble layout > 1033 | await expect(page.locator(".mx_EventTile_last")).toMatchScreenshot( | ^ 1034 | "event-tile-reply-chains-bubble-layout.png", 1035 | screenshotOptions, 1036 | ); at /home/runner/work/matrix-react-sdk/matrix-react-sdk/matrix-react-sdk/playwright/e2e/timeline/timeline.spec.ts:1033:62
[Rust Crypto] › read-receipts/redactions.spec.ts:726:17 › Read receipts › redactions › in threads › A thread with a redacted unread is still read after restart: matrix-react-sdk/playwright/e2e/read-receipts/index.ts#L462
1) [Rust Crypto] › read-receipts/redactions.spec.ts:726:17 › Read receipts › redactions › in threads › A thread with a redacted unread is still read after restart Error: Timed out 5000ms waiting for expect(locator).not.toBeVisible() Locator: getByRole('treeitem', { name: /^Room Beta/ }).locator('.mx_NotificationBadge_dot') Expected: not visible Received: visible Call log: - expect.not.toBeVisible with timeout 5000ms - waiting for getByRole('treeitem', { name: /^Room Beta/ }).locator('.mx_NotificationBadge_dot') - locator resolved to <div class="mx_NotificationBadge mx_NotificationBadge…>…</div> - unexpected value "visible" - locator resolved to <div class="mx_NotificationBadge mx_NotificationBadge…>…</div> - unexpected value "visible" - locator resolved to <div class="mx_NotificationBadge mx_NotificationBadge…>…</div> - unexpected value "visible" - locator resolved to <div class="mx_NotificationBadge mx_NotificationBadge…>…</div> - unexpected value "visible" - locator resolved to <div class="mx_NotificationBadge mx_NotificationBadge…>…</div> - unexpected value "visible" - locator resolved to <div class="mx_NotificationBadge mx_NotificationBadge…>…</div> - unexpected value "visible" - locator resolved to <div class="mx_NotificationBadge mx_NotificationBadge…>…</div> - unexpected value "visible" - locator resolved to <div class="mx_NotificationBadge mx_NotificationBadge…>…</div> - unexpected value "visible" - locator resolved to <div class="mx_NotificationBadge mx_NotificationBadge…>…</div> - unexpected value "visible" at read-receipts/index.ts:462 460 | async assertRead(room: string | { name: string }) { 461 | const tile = this.getRoomListTile(room); > 462 | await expect(tile.locator(".mx_NotificationBadge_dot")).not.toBeVisible(); | ^ 463 | await expect(tile.locator(".mx_NotificationBadge_count")).not.toBeVisible(); 464 | } 465 | at Helpers.assertRead (/home/runner/work/matrix-react-sdk/matrix-react-sdk/matrix-react-sdk/playwright/e2e/read-receipts/index.ts:462:69) at /home/runner/work/matrix-react-sdk/matrix-react-sdk/matrix-react-sdk/playwright/e2e/read-receipts/redactions.spec.ts:756:28
[Rust Crypto] › crypto/crypto.spec.ts:443:13 › Cryptography › event shields › Should show a grey padlock for a key restored from backup: matrix-react-sdk/playwright/e2e/crypto/crypto.spec.ts#L1
1) [Rust Crypto] › crypto/crypto.spec.ts:443:13 › Cryptography › event shields › Should show a grey padlock for a key restored from backup Test timeout of 30000ms exceeded.
[Rust Crypto] › crypto/crypto.spec.ts:443:13 › Cryptography › event shields › Should show a grey padlock for a key restored from backup: matrix-react-sdk/playwright/e2e/crypto/utils.ts#L162
1) [Rust Crypto] › crypto/crypto.spec.ts:443:13 › Cryptography › event shields › Should show a grey padlock for a key restored from backup Error: locator.click: Test timeout of 30000ms exceeded. Call log: - waiting for locator('.mx_AuthPage').getByRole('button', { name: 'Verify with Security Key' }) at crypto/utils.ts:162 160 | // if a securityKey was given, verify the new device 161 | if (securityKey !== undefined) { > 162 | await page.locator(".mx_AuthPage").getByRole("button", { name: "Verify with Security Key" }).click(); | ^ 163 | // Fill in the security key 164 | await page.locator(".mx_Dialog").locator('input[type="password"]').fill(securityKey); 165 | await page.locator(".mx_Dialog_primary:not([disabled])", { hasText: "Continue" }).click(); at logIntoElement (/home/runner/work/matrix-react-sdk/matrix-react-sdk/matrix-react-sdk/playwright/e2e/crypto/utils.ts:162:102) at /home/runner/work/matrix-react-sdk/matrix-react-sdk/matrix-react-sdk/playwright/e2e/crypto/crypto.spec.ts:467:13
🎭 Playwright Run Summary
44 skipped 60 passed (10.8m)
🎭 Playwright Run Summary
44 skipped 56 passed (11.2m)
🎭 Playwright Run Summary
13 skipped 88 passed (12.7m)
🎭 Playwright Run Summary
1 flaky [Legacy Crypto] › timeline/timeline.spec.ts:926:13 › Timeline › message sending › should display a reply chain 12 skipped 97 passed (13.7m)
🎭 Playwright Run Summary
3 skipped 97 passed (13.7m)
🎭 Playwright Run Summary
1 flaky [Rust Crypto] › read-receipts/redactions.spec.ts:726:17 › Read receipts › redactions › in threads › A thread with a redacted unread is still read after restart 3 skipped 96 passed (15.6m)
🎭 Playwright Run Summary
8 skipped 94 passed (16.0m)
🎭 Playwright Run Summary
1 flaky [Rust Crypto] › crypto/crypto.spec.ts:443:13 › Cryptography › event shields › Should show a grey padlock for a key restored from backup 7 skipped 89 passed (17.1m)
Slow Test: matrix-react-sdk/[Legacy Crypto] › read-receipts/high-level.spec.ts#L1
matrix-react-sdk/[Legacy Crypto] › read-receipts/high-level.spec.ts took 3.4m
Slow Test: matrix-react-sdk/[Legacy Crypto] › read-receipts/new-messages.spec.ts#L1
matrix-react-sdk/[Legacy Crypto] › read-receipts/new-messages.spec.ts took 3.4m
Slow Test: matrix-react-sdk/[Legacy Crypto] › read-receipts/editing-messages.spec.ts#L1
matrix-react-sdk/[Legacy Crypto] › read-receipts/editing-messages.spec.ts took 2.9m
Slow Test: matrix-react-sdk/[Legacy Crypto] › polls/polls.spec.ts#L1
matrix-react-sdk/[Legacy Crypto] › polls/polls.spec.ts took 42.4s
Slow Test: matrix-react-sdk/[Rust Crypto] › read-receipts/new-messages.spec.ts#L1
matrix-react-sdk/[Rust Crypto] › read-receipts/new-messages.spec.ts took 3.7m
Slow Test: matrix-react-sdk/[Rust Crypto] › read-receipts/high-level.spec.ts#L1
matrix-react-sdk/[Rust Crypto] › read-receipts/high-level.spec.ts took 3.7m
Slow Test: matrix-react-sdk/[Rust Crypto] › read-receipts/editing-messages.spec.ts#L1
matrix-react-sdk/[Rust Crypto] › read-receipts/editing-messages.spec.ts took 3.5m
Slow Test: matrix-react-sdk/[Rust Crypto] › timeline/timeline.spec.ts#L1
matrix-react-sdk/[Rust Crypto] › timeline/timeline.spec.ts took 2.8m
Slow Test: matrix-react-sdk/[Rust Crypto] › spotlight/spotlight.spec.ts#L1
matrix-react-sdk/[Rust Crypto] › spotlight/spotlight.spec.ts took 2.1m
Slow Test: matrix-react-sdk/[Rust Crypto] › spaces/threads-activity-centre/threadsActivityCentre.spec.ts#L1
matrix-react-sdk/[Rust Crypto] › spaces/threads-activity-centre/threadsActivityCentre.spec.ts took 1.6m
Slow Test: matrix-react-sdk/[Rust Crypto] › spaces/spaces.spec.ts#L1
matrix-react-sdk/[Rust Crypto] › spaces/spaces.spec.ts took 1.0m
Slow Test: matrix-react-sdk/[Rust Crypto] › threads/threads.spec.ts#L1
matrix-react-sdk/[Rust Crypto] › threads/threads.spec.ts took 36.9s
Slow Test: matrix-react-sdk/[Legacy Crypto] › spotlight/spotlight.spec.ts#L1
matrix-react-sdk/[Legacy Crypto] › spotlight/spotlight.spec.ts took 2.0m
Slow Test: matrix-react-sdk/[Legacy Crypto] › spaces/threads-activity-centre/threadsActivityCentre.spec.ts#L1
matrix-react-sdk/[Legacy Crypto] › spaces/threads-activity-centre/threadsActivityCentre.spec.ts took 1.5m
Slow Test: matrix-react-sdk/[Rust Crypto] › audio-player/audio-player.spec.ts#L1
matrix-react-sdk/[Rust Crypto] › audio-player/audio-player.spec.ts took 1.3m
Slow Test: matrix-react-sdk/[Legacy Crypto] › spaces/spaces.spec.ts#L1
matrix-react-sdk/[Legacy Crypto] › spaces/spaces.spec.ts took 1.0m
Slow Test: matrix-react-sdk/[Legacy Crypto] › settings/general-user-settings-tab.spec.ts#L1
matrix-react-sdk/[Legacy Crypto] › settings/general-user-settings-tab.spec.ts took 35.3s
Slow Test: matrix-react-sdk/[Legacy Crypto] › read-receipts/redactions.spec.ts#L1
matrix-react-sdk/[Legacy Crypto] › read-receipts/redactions.spec.ts took 5.2m
Slow Test: matrix-react-sdk/[Legacy Crypto] › read-receipts/reactions.spec.ts#L1
matrix-react-sdk/[Legacy Crypto] › read-receipts/reactions.spec.ts took 2.2m
Slow Test: matrix-react-sdk/[Legacy Crypto] › read-receipts/read-receipts.spec.ts#L1
matrix-react-sdk/[Legacy Crypto] › read-receipts/read-receipts.spec.ts took 1.0m
Slow Test: matrix-react-sdk/[Legacy Crypto] › settings/appearance-user-settings-tab.spec.ts#L1
matrix-react-sdk/[Legacy Crypto] › settings/appearance-user-settings-tab.spec.ts took 55.0s
Slow Test: matrix-react-sdk/[Legacy Crypto] › right-panel/right-panel.spec.ts#L1
matrix-react-sdk/[Legacy Crypto] › right-panel/right-panel.spec.ts took 51.2s
Slow Test: matrix-react-sdk/[Rust Crypto] › read-receipts/reactions.spec.ts#L1
matrix-react-sdk/[Rust Crypto] › read-receipts/reactions.spec.ts took 2.5m
Slow Test: matrix-react-sdk/[Rust Crypto] › read-receipts/read-receipts.spec.ts#L1
matrix-react-sdk/[Rust Crypto] › read-receipts/read-receipts.spec.ts took 1.2m
Slow Test: matrix-react-sdk/[Rust Crypto] › settings/appearance-user-settings-tab.spec.ts#L1
matrix-react-sdk/[Rust Crypto] › settings/appearance-user-settings-tab.spec.ts took 1.0m
Slow Test: matrix-react-sdk/[Rust Crypto] › right-panel/right-panel.spec.ts#L1
matrix-react-sdk/[Rust Crypto] › right-panel/right-panel.spec.ts took 57.8s
Slow Test: matrix-react-sdk/[Rust Crypto] › room/room-header.spec.ts#L1
matrix-react-sdk/[Rust Crypto] › room/room-header.spec.ts took 55.9s
Slow Test: matrix-react-sdk/[Legacy Crypto] › crypto/verification.spec.ts#L1
matrix-react-sdk/[Legacy Crypto] › crypto/verification.spec.ts took 2.7m
Slow Test: matrix-react-sdk/[Legacy Crypto] › crypto/crypto.spec.ts#L1
matrix-react-sdk/[Legacy Crypto] › crypto/crypto.spec.ts took 2.0m
Slow Test: matrix-react-sdk/[Legacy Crypto] › audio-player/audio-player.spec.ts#L1
matrix-react-sdk/[Legacy Crypto] › audio-player/audio-player.spec.ts took 1.5m
Slow Test: matrix-react-sdk/[Legacy Crypto] › crypto/staged-rollout.spec.ts#L1
matrix-react-sdk/[Legacy Crypto] › crypto/staged-rollout.spec.ts took 1.1m
Slow Test: matrix-react-sdk/[Legacy Crypto] › composer/composer.spec.ts#L1
matrix-react-sdk/[Legacy Crypto] › composer/composer.spec.ts took 1.1m
Slow Test: matrix-react-sdk/[Rust Crypto] › crypto/verification.spec.ts#L1
matrix-react-sdk/[Rust Crypto] › crypto/verification.spec.ts took 2.8m
Slow Test: matrix-react-sdk/[Rust Crypto] › composer/composer.spec.ts#L1
matrix-react-sdk/[Rust Crypto] › composer/composer.spec.ts took 1.5m
Slow Test: matrix-react-sdk/[Rust Crypto] › integration-manager/kick.spec.ts#L1
matrix-react-sdk/[Rust Crypto] › integration-manager/kick.spec.ts took 39.8s
Slow Test: matrix-react-sdk/[Rust Crypto] › knock/knock-into-room.spec.ts#L1
matrix-react-sdk/[Rust Crypto] › knock/knock-into-room.spec.ts took 39.5s
Slow Test: matrix-react-sdk/[Rust Crypto] › polls/polls.spec.ts#L1
matrix-react-sdk/[Rust Crypto] › polls/polls.spec.ts took 36.6s

Artifacts

Produced during runtime
Name Size
all-blob-reports-1 Expired
1.45 MB
all-blob-reports-2 Expired
639 KB
all-blob-reports-3 Expired
974 KB
all-blob-reports-4 Expired
4.69 MB
all-blob-reports-5 Expired
14.3 MB
all-blob-reports-6 Expired
579 KB
all-blob-reports-7 Expired
5.76 MB
all-blob-reports-8 Expired
1.13 MB
webapp Expired
38 MB