Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code smell assertion identified by Sonar #12547

Merged
merged 5 commits into from
May 21, 2024
Merged

Remove code smell assertion identified by Sonar #12547

merged 5 commits into from
May 21, 2024

Conversation

EdGeraghty
Copy link
Contributor

@EdGeraghty EdGeraghty commented May 17, 2024 •
edited

This assertion is unnecessary since the receiver accepts the original…

(picked up by SonarCloud)

Signed-off-by: Ed Geraghty ed@geraghty.family

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@EdGeraghty EdGeraghty requested a review from a team as a code owner May 17, 2024 18:17
@EdGeraghty EdGeraghty requested review from dbkr and robintown May 17, 2024 18:17
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label May 17, 2024
@EdGeraghty EdGeraghty changed the title Remove code smell assrertion identified by Sonar Remove code smell assertion identified by Sonar May 17, 2024
@EdGeraghty
Copy link
Contributor Author

🤣 Playwright doesn't like that.

dbkr
dbkr requested changes May 20, 2024
View reviewed changes
src/SlidingSyncManager.ts Outdated Show resolved Hide resolved
EdGeraghty
EdGeraghty commented May 20, 2024
View reviewed changes
Copy link
Contributor Author

@EdGeraghty EdGeraghty left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Derp.

@EdGeraghty
Copy link
Contributor Author

Thanks for your help, @dbkr

@EdGeraghty EdGeraghty requested a review from dbkr May 21, 2024 11:50
dbkr
dbkr reviewed May 21, 2024
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise though, thanks for updating it!

src/SlidingSyncManager.ts Outdated Show resolved Hide resolved
@EdGeraghty EdGeraghty requested a review from dbkr May 21, 2024 12:17
@dbkr dbkr added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 21, 2024
@dbkr dbkr added this pull request to the merge queue May 21, 2024
Merged via the queue into matrix-org:develop with commit f712b80 May 21, 2024
31 of 32 checks passed
@EdGeraghty EdGeraghty deleted the EdGeraghty/ss-code-smell branch May 21, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EdGeraghty @dbkr