Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mask lookup in fill_between for NumPy 1.24+ #24115

Merged
merged 1 commit into from Oct 7, 2022

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Oct 7, 2022

PR Summary

I did not bother adding any new tests, as the existing tests will already break with the latest nightly NumPy wheels.

Fixes #24106

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@QuLogic QuLogic added this to the v3.6.1 milestone Oct 7, 2022
@oscargus
Copy link
Contributor

oscargus commented Oct 7, 2022

Semi-related: there are still uses of getmask in other parts of the code. Would it be worthwhile revisiting those and replace with getmaskarray? I assume that most of the time we do want an array and that many of those may break with the "wrong" input data?

@timhoffm timhoffm merged commit 6f137b9 into matplotlib:main Oct 7, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 7, 2022
@QuLogic QuLogic deleted the fix-maskarray-np124 branch October 7, 2022 08:07
@QuLogic
Copy link
Member Author

QuLogic commented Oct 7, 2022

Possibly, but none of them triggered a test failure with latest NumPy wheels, other than this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: fill_between gives IndexError with numpy 1.24.0.dev
3 participants