Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing new features of website theme #11033

Merged
merged 9 commits into from Oct 7, 2022

Conversation

drammock
Copy link
Member

cc @choldgraf

When the CircleCI build is done here, it should demonstrate the "empty right-side TOC" on the MNE homepage and on the first page after that in the TOCtree (install/index.html)

@drammock drammock changed the title DO NOT MERGE: debugging PR for the upstream theme testing new features of website theme Oct 6, 2022
@drammock drammock marked this pull request as ready for review October 7, 2022 14:51
@drammock
Copy link
Member Author

drammock commented Oct 7, 2022

@larsoner this is ready. Only CI failure should go away with matplotlib/matplotlib#24115

@larsoner
Copy link
Member

larsoner commented Oct 7, 2022

The only possible regression I noticed is that it used to say 1.2 (dev) and now it just says dev in the dropdown. But I think that's fine. Otherwise all the changes look like slightly better layouts and CSS. And great to see more - than +. Thanks @drammock !

@larsoner larsoner merged commit f55c5ea into mne-tools:main Oct 7, 2022
@larsoner
Copy link
Member

larsoner commented Oct 7, 2022

I ran with a [circle deploy] so we can see the full output later today

@drammock drammock deleted the DNM-theme-debugging branch October 7, 2022 16:48
larsoner added a commit to larsoner/mne-python that referenced this pull request Oct 11, 2022
* upstream/main:
  BUG: Avoid warning in report.add_ica (mne-tools#11232)
  testing new features of website theme [circle deploy] (mne-tools#11033)
  BUG: Fix regression with run_subprocess (mne-tools#11230)
  DOC:  fix mne-kit-gui package name (mne-tools#11231)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants