Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/ethapi: set rpc gas cap as default gas limit when creating access list #791

Merged
merged 1 commit into from Mar 27, 2023

Conversation

Raneet10
Copy link
Member

Description

In this PR, while creating access list we default to rpc gas cap when gas limit isn't provided in the transaction args instead of re-estimating for every list. See ethereum/go-ethereum#25467

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

@Raneet10 Raneet10 requested a review from a team March 27, 2023 10:04
@Raneet10 Raneet10 merged commit b0ff49d into develop Mar 27, 2023
11 of 13 checks passed
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 75.50% and project coverage change: +0.04 🎉

Comparison is base (808259b) 56.60% compared to head (08a871c) 56.65%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #791      +/-   ##
===========================================
+ Coverage    56.60%   56.65%   +0.04%     
===========================================
  Files          610      610              
  Lines        71266    71572     +306     
===========================================
+ Hits         40339    40546     +207     
- Misses       27466    27550      +84     
- Partials      3461     3476      +15     
Impacted Files Coverage Δ
consensus/bor/bor.go 7.50% <0.00%> (-0.03%) ⬇️
consensus/bor/valset/validator_set.go 49.25% <0.00%> (-0.38%) ⬇️
core/blockchain.go 59.48% <ø> (ø)
core/rawdb/bor_receipt.go 1.23% <ø> (ø)
core/types/transaction_signing.go 67.23% <0.00%> (-2.37%) ⬇️
core/vm/contracts.go 77.84% <ø> (ø)
eth/backend.go 0.00% <0.00%> (ø)
eth/filters/bor_api.go 0.00% <ø> (ø)
internal/cli/dumpconfig.go 0.00% <0.00%> (ø)
internal/cli/server/chains/developer.go 0.00% <0.00%> (ø)
... and 14 more

... and 21 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants