Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calling eth_createAccessList without gas field causes bor to go insane #748

Closed
eyooooo opened this issue Feb 18, 2023 · 6 comments
Closed
Assignees

Comments

@eyooooo
Copy link

eyooooo commented Feb 18, 2023

continuously call eth_createAccessList on a tx without gas specified in pending and bor spikes to 100% cpu and crashes

@eyooooo
Copy link
Author

eyooooo commented Feb 21, 2023

Hi @eyooooo Go to the Official page to initiate a chat with an agent on a live chat to report this for review and assist via Live chat

gud skem A+

@Raneet10
Copy link
Member

Raneet10 commented Mar 2, 2023

Hi @eyooooo , thanks for reporting the issue! Could you please also list out the steps and the rpc call params so that we can reproduce at our end ?

@eyooooo
Copy link
Author

eyooooo commented Mar 8, 2023

Hi @eyooooo , thanks for reporting the issue! Could you please also list out the steps and the rpc call params so that we can reproduce at our end ?

sniff new blocks, iterate over tx within block, create a new tx object for every tx but omit the gas field, call eth_createaccesslist using the new tx object. run that for 20 seconds.

bor will crash.

@Raneet10
Copy link
Member

Raneet10 commented Mar 21, 2023

Hey @eyooooo , sorry for the delay but if you're using a script specifically, would you please share that so that we can reproduce the behaviour deterministically at our end as well ? Also, logs during the panic will also be quite helpful. Thanks!

@Raneet10
Copy link
Member

Hi @eyooooo , I believe what you might've faced is an EVM level revert instead of bor client crashing. Nevertheless, we found a minor inconsistency in gas limit calculation while creating the access lists. #791 aims to fix this by setting the RPC gas cap as the gas limit if gas isn't provided in transaction args. Feel free to reopen the issue if the problem you faced was different.

@eyooooo
Copy link
Author

eyooooo commented Mar 27, 2023

Hi @eyooooo , I believe what you might've faced is an EVM level revert instead of bor client crashing. Nevertheless, we found a minor inconsistency in gas limit calculation while creating the access lists. #791 aims to fix this by setting the RPC gas cap as the gas limit if gas isn't provided in transaction args. Feel free to reopen the issue if the problem you faced was different.

thanks!!!! i will reopen if i find a new issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants