Do not introduce zero magmoms in SpacegroupAnalyzer #2727
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not introduce zero
magmoms
inSpacegroupAnalyzer
following changes in spglib >= 2. See #2725TODO
Checklist
Work-in-progress pull requests are encouraged, but please put [WIP]
in the pull request title.
Before a pull request can be merged, the following items must be checked:
Run pydocstyle on your code.
mypy
path/to/file.py
to type check your code.Note that the CI system will run all the above checks. But it will be much more efficient if you already fix most
errors prior to submitting the PR. We highly recommended installing
pre-commit
hooks. Simplypip install -U pre-commit && pre-commit install
in the repo's root directory. Afterwards linters will run before every commit and abort if any issues pop up.