Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not introduce zero magmoms in SpacegroupAnalyzer #2727

Merged
merged 3 commits into from
Nov 8, 2022
Merged

Do not introduce zero magmoms in SpacegroupAnalyzer #2727

merged 3 commits into from
Nov 8, 2022

Commits on Nov 8, 2022

  1. do not introduce zero magmoms in SpacegroupAnalyzer

    @lbluque
    lbluque committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    d39aa9f View commit details
    Browse the repository at this point in the history

  2. fix mypy error

    @janosh
    janosh committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    ba08bc0 View commit details
    Browse the repository at this point in the history

  3. fix test_get_symmetry() 

    modify sga._cell in place to make sure ValueError is raised
    @janosh
    janosh committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    803d750 View commit details
    Browse the repository at this point in the history