Adapt to pymatgen 2023.07.20 update. #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps the issue with the number of symmetry operations is related to this PR made some months ago materialsproject/pymatgen#2727 |
Submitted a bug fix, see materialsproject/pymatgen#3179 |
Wonderful! Thank you so much for taking care of this! |
lbluque
requested changes
Jul 24, 2023
for more information, see https://pre-commit.ci
…nstraints instability. DOC: Added corresponding warning in the ground-state notebook.
|
Thanks a lot @qchempku2017 ! |
lbluque
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Additional dependencies introduced (if any)
TODO (if any)
Checklist
Run pycodestyle and flake8
on your local machine.
Run pydocstyle on your code.