mongoclient_kwargs #575
Merged
mongoclient_kwargs #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #575 +/- ##
==========================================
+ Coverage 89.11% 89.13% +0.01%
==========================================
Files 40 40
Lines 2794 2797 +3
==========================================
+ Hits 2490 2493 +3
Misses 304 304
Continue to review full report at Codecov.
|
munrojm
reviewed
Mar 4, 2022
src/maggma/stores/mongolike.py
Outdated
| @@ -564,7 +567,7 @@ def connect(self, force_reset: bool = False): | |||
| Connect to the source data | |||
| """ | |||
| if self._coll is None or force_reset: # pragma: no cover | |||
| conn = MongoClient(self.uri) | |||
| conn = MongoClient(self.uri, self.mongodb_client_kwargs) | |||
There was a problem hiding this comment.
I think this needs **self.mongoclient_kwargs, no?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows additional kwargs to be passed to
MongoClientin different stores that containMongoClientinits.