Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo #576

Merged
merged 2 commits into from Mar 7, 2022
Merged

typo #576

merged 2 commits into from Mar 7, 2022

Conversation

jmmshn
Copy link
Contributor

@jmmshn jmmshn commented Mar 5, 2022

Sorry there was a really dumb typo in the last PR #575
I blame auto complete

@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #576 (fe7ffe6) into main (515c74f) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
- Coverage   89.13%   89.12%   -0.01%     
==========================================
  Files          40       40              
  Lines        2797     2796       -1     
==========================================
- Hits         2493     2492       -1     
  Misses        304      304              
Impacted Files Coverage Δ
src/maggma/api/utils.py 97.01% <ø> (-0.05%) ⬇️
src/maggma/stores/mongolike.py 86.84% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 515c74f...fe7ffe6. Read the comment docs.

@jmmshn
Copy link
Contributor Author

jmmshn commented Mar 7, 2022

@munrojm looks like codecov is doing something freaky?

@munrojm
Copy link
Member

munrojm commented Mar 7, 2022

Yeah, I am really am not sure what is going on. I am going to merge this and get a patch release out another way.

@munrojm munrojm merged commit 65852ab into materialsproject:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants