-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for EOL Python 2.7 #454
Conversation
Thank you so much for your work on this, @hugovk. |
You're welcome! Python 3.5 failed, I guess it needs some backports the non-stdlib |
Updated and now ✅! |
Updated and now ✅! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I suspect simplejson
was used in PY2 to compensate for shortcomings in core json
.
We should also test against 3.8. Let's do that in another PR.
Yeah, the simplejson import can be removed, as it was only for Python 2 compat Lines 7 to 8 in c90e814
|
Does that mean we should use universal wheels? diff --git a/setup.cfg b/setup.cfg
[bdist_wheel]
-# We build separate wheels for
-# Python 2 and 3 because of the conditional
-# dependency on simplejson
-universal = 0
+universal = 1 |
Yes, good catch. We can build universal wheels now. |
Updated! |
Great. Let's move on with this. |
Released as 6.0.0b2 ! Thanks again @hugovk. |
You're welcome! |
For #440.