Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python 2.7 #454

Merged
merged 9 commits into from
Jan 7, 2020
Merged

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jan 3, 2020

For #440.

@lafrech
Copy link
Member

lafrech commented Jan 3, 2020

Thank you so much for your work on this, @hugovk.

@hugovk
Copy link
Contributor Author

hugovk commented Jan 3, 2020

You're welcome! Python 3.5 failed, I guess it needs some backports the non-stdlib mock package, but will check back in a bit.

@hugovk
Copy link
Contributor Author

hugovk commented Jan 3, 2020

Updated and now ✅!

@hugovk hugovk mentioned this pull request Jan 3, 2020
2 tasks
@sloria
Copy link
Member

sloria commented Jan 5, 2020

@hugovk Can you resolve the conflicts?

Once that's done and 6.0.0b1 is released, I think we're good to merge and release this cc @lafrech

@hugovk
Copy link
Contributor Author

hugovk commented Jan 6, 2020

Updated and now ✅!

Copy link
Member

@lafrech lafrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I suspect simplejson was used in PY2 to compensate for shortcomings in core json.

We should also test against 3.8. Let's do that in another PR.

src/webargs/core.py Outdated Show resolved Hide resolved
@sloria
Copy link
Member

sloria commented Jan 6, 2020

Yeah, the simplejson import can be removed, as it was only for Python 2 compat

webargs/setup.py

Lines 7 to 8 in c90e814

if sys.version_info[0] < 3:
INSTALL_REQUIRES.append("simplejson>=2.1.0")

@hugovk
Copy link
Contributor Author

hugovk commented Jan 6, 2020

Does that mean we should use universal wheels?

diff --git a/setup.cfg b/setup.cfg
 [bdist_wheel]
-# We build separate wheels for
-# Python 2 and 3 because of the conditional
-# dependency on simplejson
-universal = 0
+universal = 1

@sloria
Copy link
Member

sloria commented Jan 6, 2020

Yes, good catch. We can build universal wheels now.

@hugovk
Copy link
Contributor Author

hugovk commented Jan 6, 2020

Updated!

@lafrech
Copy link
Member

lafrech commented Jan 7, 2020

Great. Let's move on with this.

@lafrech lafrech merged commit 6e1c155 into marshmallow-code:dev Jan 7, 2020
@hugovk hugovk deleted the rm-2 branch January 7, 2020 08:50
@lafrech
Copy link
Member

lafrech commented Jan 7, 2020

Released as 6.0.0b2 !

Thanks again @hugovk.

@hugovk
Copy link
Contributor Author

hugovk commented Jan 7, 2020

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants