Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 2 #440

Closed
2 tasks done
lafrech opened this issue Nov 13, 2019 · 7 comments
Closed
2 tasks done

Drop Python 2 #440

lafrech opened this issue Nov 13, 2019 · 7 comments
Milestone

Comments

@lafrech
Copy link
Member

lafrech commented Nov 13, 2019

Let's wait on #420 to be merged first to avoid a painful rebase.

  • Drop Python 2
  • Make arguments keyword-only where sensible

Do we also want to drop Python 3.5 ? This can be done in a later major release.

@lafrech lafrech added this to the 6.0.0 milestone Nov 13, 2019
@sloria
Copy link
Member

sloria commented Nov 13, 2019

Wrote up a checklist recently for this: https://gist.github.com/sloria/b4a5fc2281f86a5733af198d609c5ab3

@sirosen
Copy link
Collaborator

sirosen commented Dec 9, 2019

I wanted to chime in with my $0.02: I wouldn't drop py3.5 support yet because it's the py3 version shipped on several distro versions, notably Ubuntu 16.04.
Since so many people are using Ubuntu as their first distro, and there's the WSL stuff on Windows, there's some reason to give the Ubuntu lifecycle "priority" when looking at the landscape of distros.

By way of example, if someone is using webargs but they're having trouble upgrading from Ubuntu 16.04 infrastructure to Ubuntu 18.04, then they wouldn't be able to move to the new webargs without either (A) fixing their platform version issues or (B) installing another python version alongside the system python. (Yes, they should fix their problems, but my experience is that by the time you're even talking about being stuck on an old platform version, you're in trouble.)

The same argument doesn't apply to forcing the py2 -> py3 transition -- I'm 👍 on dropping py2.

@lafrech
Copy link
Member Author

lafrech commented Dec 10, 2019

Yeah, no pressure to remove py35 soon. Can be done later.

@sloria
Copy link
Member

sloria commented Dec 10, 2019

Sounds good. I'm fine keeping support for 3.5 for now.

@lafrech
Copy link
Member Author

lafrech commented Jan 3, 2020

Summoning @hugovk again.

Would you be willing to tackle this?

Just asking. I don't know if you even use webargs.

@hugovk
Copy link
Contributor

hugovk commented Jan 3, 2020

Happy to help with Python 3 migration!

Please see PR #454 for the first checkbox item: " Drop Python 2".

The second checkbox "Make arguments keyword-only where sensible" can follow in another PR.

@sirosen
Copy link
Collaborator

sirosen commented Feb 14, 2020

With #472 merged, we can call this done!

I just did a check on the repo looking for anything python2-related I could find and it came up blank.

@sirosen sirosen closed this as completed Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants