New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 332: to address column typo asper doc #461
fix 332: to address column typo asper doc #461
Conversation
Thanks. This makes sense. I'm surprised this doesn't seem to trigger warnings in the tests. Adding a test using the feature and one triggering the warning would be nice. Please also add yourself to authors file. |
6bd63ef
to
b609539
Compare
ffda44b
to
87e7ef8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Just a minor comment.
87e7ef8
to
102dc6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
I don't have permissions to push to dev branch. @sloria, if you pass by, here's the changelog I was writing.
|
@lafrech changelog looks good to me.
odd, i just checked the repo settings and i don't see anything that should block you. i bumped you up to have |
I'm one commit ahead of dev and I try to push.
We've seen this already and I don't remember what solved it.
Looks like a branch protection issue. I don't think I have access to that in the settings. I'm surprised that the status of maintainer doesn't let me bypass this, though. (I didn't mean to become a maintainer, but since I use this lib I thought I'd do what I can to help so I use my merge permission to help merging automatic and occasional PRs. I don't know the code enough to provide real contributions.) |
Attempt to address #332 ,
based on API documentation parameters section asks for columns but class parameter accepts column.
added a deprecation warning for column with message to use columns instead