-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQLAlchemy 2.0 support #488
Comments
@lafrech +💯 on this plan. i've given you owner access in both GH and pypi. let me know if you're still missing privs |
Thanks. Now I need to carve out time to follow the plan. |
0.28.2 released. For some reason the automatic release failed so I released manually. I'll investigate this another day, it's late. SQLA 1.3 support dropped in dev branch. (Edit: I didn't find it yesterday. Here's the SQLA page saying 1.3 is EOL: https://www.sqlalchemy.org/download.html#status-desc-eol.) |
So now we locked into 2 dependencies until it is solved: Majority of marshmallow works with 2.0.1 version but does not work with anything above it. Since we start changing our code to support 2.0.1 we can not upgrade marshmallow, since dependency lock was much later introduced than SQLAlchemy. |
@lafrech URL which you mentioned above does not seem to be working Let me know if we have branch or some base for SQLAlchemy 2.0 support. |
Thanks @rimvisit for the help. The branch I mentioned above was merged already. I believe I solved all 2.0 compat warnings. Migration steps here: https://docs.sqlalchemy.org/en/20/changelog/migration_20.html. We should be pretty close to the "test against SQLAlchemy 2.0" step. |
SQLAlchemy 2.0 support merged in #495. Shipping soon. Time to test on your code bases to spot issues that would have been uncaught. |
Thank you I will try to get it tested. |
Allright, I decided I had enough feedback already. SQLAlchemy 2.0 support is achieved in marshmallow-sqlalchemy 0.29.0, available today at your favorite store. |
Thank you @lafrech! |
marshmallow-sqlalchemy does not support sqlalchemy 2.0+.
This is what I think we should do:
Then in a second step
(We may still accept bugfixes in 0.28.x branch for a while.)
What I need:
@sloria do you think you could give me ownership of this repo or at least the same privileges as marshmallow, and either share PyPI ownership or provide API_KEY?
I didn't really mean to maintain this. I'm not familiar with the code base. But we use it and will need 2.0 support, and no one stepped in to take over, so I can try to do my best with maintenance chores.
The text was updated successfully, but these errors were encountered: