Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set "access_type=offline" to google provider as default #396

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

shiwano
Copy link
Contributor

@shiwano shiwano commented Feb 15, 2021

I set access_type=offline as default, referring to #315 (comment)

Related PRs: #347 #315

@pascalbros
Copy link

Any hope for this PR? Super useful!

@pascalbros
Copy link

@markbates would you wanna be my hero and merge this PR? Thanks. 🦸‍♂️
Cheers bud.

@pascalbros
Copy link

@benja-M-1
Copy link

@uded
Copy link

uded commented Oct 4, 2021

OK, then who is actually maintaining this library? Is anyone doing that at all???

@techknowlogick
Copy link
Collaborator

I have reached out to Mark about volunteering to maintain goth, and hopefully will hear back.

@bentranter
Copy link
Collaborator

bentranter commented Oct 5, 2021

Hey folks, sorry, I've been struggling to find time to maintain this library over the last few months. I'll merge this, but hopefully @techknowlogick is assigned a maintainer by Mark, as I don't have permissions to add new maintainers.

@bentranter bentranter merged commit 9e679fb into markbates:master Oct 5, 2021
@uded
Copy link

uded commented Oct 9, 2021

@bentranter thanks for the merge! But I do believe that #315 would be quite beneficial as well. Unfortunately, it has a conflict which would have to be resolved...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants