Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom auth code options for google #315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gregadams4
Copy link

Might just be missing something, but couldn't find a way currently to set access_type=offline to get a refresh token for this provider

@bentranter
Copy link
Collaborator

@gregadams4 Thanks for bringing this up! I we should instead set access_type=offline by default. As stated in Google's documentation,

Set the value to offline if your application needs to refresh access tokens when the user is not present at the browser.

I feel like that covers the authentication use case for Goth. We also used to set it by default on the old gplus provider, so I think it'd be better to have that as the default here for consistency.

@jmburges
Copy link

🤞 this gets merged soon!

@uded
Copy link

uded commented Jun 30, 2021

Can someone check, fix and merge this? This is a crucial update from the perspective of using Google auth for something more than just login...
This or #396 -- whatever seems to be better for goth.

@uded
Copy link

uded commented Oct 9, 2021

After using a newly merged #396 I have to say this would be a bit better. With a default for access_type=offline. But sometimes I do need to add refresh_token or something like that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants