Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin back pre-commit due to incompatibilities on windows #33675

Merged
merged 1 commit into from Mar 18, 2022

Conversation

Pasarus
Copy link
Contributor

@Pasarus Pasarus commented Mar 17, 2022

Description of work.
ad to pin back to 2.15 as we can't handle changes made here (pre-commit/pre-commit#2065 added in 2.16) on windows yet. Longer term we should change how we handle windows pre-commit, but we have no reason to put in the work yet.

To test:

  • Create a fresh conda environment in windows
  • Using a fresh clone of the mantid source configure cmake
  • Change some code and try to commit these changes
  • Pre-commit should run

There is no associated issue.

This does not require release notes because Not user facing


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Are the release notes saved in a separate file, using Issue or PR number for file name and in the correct location?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

@Pasarus Pasarus added the ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS label Mar 17, 2022
@thomashampson thomashampson self-assigned this Mar 18, 2022
Copy link
Contributor

@thomashampson thomashampson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the problem. We'll have to consider this when moving all our version numbers to a single place.

@martyngigg martyngigg merged commit a4da02a into main Mar 18, 2022
@martyngigg martyngigg deleted the pin_pre-commit_on_windows branch March 18, 2022 10:39
@jclarkeSTFC jclarkeSTFC mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants