Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin pre-commit #36522

Merged
merged 1 commit into from Dec 8, 2023
Merged

Unpin pre-commit #36522

merged 1 commit into from Dec 8, 2023

Conversation

jclarkeSTFC
Copy link
Contributor

@jclarkeSTFC jclarkeSTFC commented Dec 7, 2023

I recently started getting the following error when trying to commit:

An error has occurred: InvalidManifestError: 
==> File C:\Users\qhq63562\.cache\pre-commit\repokc8xv_bl\.pre-commit-hooks.yaml
==> At Hook(id='black')
==> At key: stages
==> At index 0
=====> Expected one of commit, commit-msg, manual, merge-commit, post-checkout, post-commit, post-merge, post-rewrite, prepare-commit-msg, push but got: 'pre-commit'

Unpinning pre-commit on Windows fixed this problem and seemed okay for me, would be good if there's no need for the pin anymore. The version I updated to was 3.5.0.

Description of work

Purpose of work

Lets me commit.

To test:

I'd test git commit on Windows to check it works for you.

This does not require release notes because it's not user-facing.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@jclarkeSTFC jclarkeSTFC marked this pull request as ready for review December 7, 2023 16:36
@thomashampson thomashampson added ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Added during Sprint Tasks that were added after initial sprint planning labels Dec 8, 2023
@thomashampson thomashampson self-assigned this Dec 8, 2023
Copy link
Contributor

@thomashampson thomashampson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the problem introduced by the recent pre-commit update, and now the pinning is consistent across all OS.

@thomashampson thomashampson merged commit 258c815 into main Dec 8, 2023
9 checks passed
@thomashampson thomashampson deleted the unpin_pre_commit_win branch December 8, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added during Sprint Tasks that were added after initial sprint planning ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants