add test for false negative on multipleOf #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pubkey
added a commit
to pubkey/rxdb
that referenced
this pull request
Jul 22, 2022
pubkey
added a commit
to pubkey/rxdb
that referenced
this pull request
Aug 5, 2022
* RENAME the `ajv-validate` plugin to `validate-ajv` to be in equal with the other validation plugins. * FIX wrong filenames * REFACTORED the validation plugins * FIX ci * FIX ci * FIX ci * FIX tests * ADD run test suite once with validation * FIX naming * REFACTORED the [key compression plugin](https://rxdb.info/key-compression.html), it is no longer a plugin but now a wrapper around any other RxStorage. * FIX tests * FIX lint * REFACTORED the encryption plugin, it is no longer a plugin but now a wrapper around any other RxStorage * REMOVED many unused plugin hooks because they decreased the performance. * FIX tests * FIX pouchdb testss * FIX loki tests * REMOVE logs * FIX node tests * ADD debug for loki failure * FIX lokijs tests * REMOVED support for temporary documents * FIX lint * REMOVED RxDatabase.broadcastChannel * FIX tests * FIX test * FIX angular example * ADD debug log for loki * ADD logs * aDD log * MOVE test * CHANGE karma use better reporter * FIX karma config * FIX lokijs test * fix react-native expo example * rxdb installs from current branch * ADD hint for mafintosh/is-my-json-valid#192 * CHANGE In RxDB `_meta.lwt` field, we now use 2 decimal number of the unix timestamp in milliseconds * REPLACE is-my-json-valid with ajv * REMOVE ajv strict mode * FIX svelte example * REFACTOR revision handling step 1 * CHANGE store the password hash in the same write request as the database token to improve performance * FIX tests * FIX tests * FIX import * REMOVE RxStorageStatics `.hash` and `.hashKey` * FIX tests * FIX tests * FIX tests * FIX tests * FIX lint * CHANGE removed default usage of `md5` as default hashing. Use a faster non-cryptographic hash instead * FIX deps * CHANGE use new replication protocol step 1 * FIX stuff for new replication * FIX more replication tests * FIX more graphql tests * FIX more graphql tests * FIX more graphql tests * FIX pouchdb test * FIX pouchdb tset * FIX dexie.js tests * FIX some more tests * FIX ci * ADD(docs) new replication protocol * REMOVE liveInterval option from replication * ADD logs for randomly failing test * ADD logs for randomly failing test 2 * ADD logs for randomly failing test 3 * ADD logs for randomly failing test 4 * ADD logs for randomly failing test 5 * CHANGE use `Float` instead of `Int` to represent timestamps in GraphQL * REMOVED support for the `deletedFlag` in the GraphQL replication. Use a [GraphQL alias](https://devinschulz.com/rename-fields-by-using-aliases-in-graphql/) instead. * REPLACED `RxReplicationPullError` and `RxReplicationPushError` with normal `RxError` like in the rest of the RxDB code * REMOVED the option to filter out replication documents with the push/pull modifiers [#2552](#2552) because this does not work with the new replication protocol * FIX handle schema validation errors on replication * REFACTOR graphql replication plugin * ADD more docs for replication * ADD docs * CHANGE default of replication `live` to be set to `true`. Because most people want to do a live replication, not a one time replication. * ADD(graphql-replication) pull.stream$ * FIX types * FIX closing of sockets * FIX import of isomorphic-ws * FIX deps check * FIX graphql query builders * FIX graphql example step 1 * FIX graphql stream replication * FIX graphql example * FIX lint * FIX angular example * FIX deps check * RENAME bulkSize to batchSize * ADD deletedFlag * FIX tests * FIX tests * FIX handling of deletedField * CHANGED Attachment data is now always handled as `Blob` because Node.js does support `Blob` since version 18.0.0 so we no longer have to use a `Buffer` but instead can use Blob for browsers and Node.js * FIX types * FIX base64 handling of attachments data * FIX pouchdb attachment handling * FIX deleted field can be truthy * IMPROVE logs * FINISH docs for graphql replication * FIX electron example * FIX electron remote example * FIX install script * FIX tests Co-authored-by: msotnikov <mishichka@gmail.com>
linco95
added a commit
to linco95/is-my-json-valid
that referenced
this pull request
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using multipleOf
0.01fails to validate a big number that does not contain a decimal part.1658529657949.05is valid, as it should be.165is valid, as it should be.1658529657949is not valid, but should be valid.NOTICE: This PR adds a failing test, but it does not contain a proper solution. Do not merge this without a fix.