Fixed PR #192 (multipleOf decimal with big integer value) #193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#192
The issue seemed to be that
number | 0 !== number
to detect integers doesn't work for big numbers. I replaced it with theNumber.isInteger
function, which seems to handle all test cases quite wellAlso inverted the ternary operator to avoid the negation. I also suggest replacing
multipleOf.toString().split('.').pop().length
with a named functionconst getDecimalPart = (num) => num.toString().split(".").pop();
const getNumberOfDecimals = (num) => getDecimalPart(num).length;
var factor = Number.isInteger(multipleOf) ? 1 : Math.pow(10, getNumberOfDecimals(multipleOf))