New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read config from pyproject.toml #152
Read config from pyproject.toml #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super awesome contribution! thank you so much. Your code is beautiful and follows the project style flawlessly.
It makes sense to me too to add the functionality in two separate pull requests, although if you change your mind and want to add everything here it's OK too
Also one question, I don't know why I don't see the CI results in this PR, I had to navigate to the Actions tab. Is it only me? or you don't see them either? It's weird because it didn't gave me the option to enable the CI actions, which usually does when a new contributor opens a PR |
hmm yeah i don't see it either, strange |
Thank you so much @dbatten5 for the contribution. I'll wait until a real use case is implemented in order to make a new release |
add support for loading and reading from an
autoimport
config section in apyproject.toml
file - the first part of the work needed for #148. i thought this could go in first as its own pr, then the actual config option needed for #148 could follow in another pr, but if you prefer it as one pr then happy to go ahead with that.4cd0231
Add
utils
module andpyproject
utils1a38f61
Add
AutoImportConfig
class to find and parse config files0e831fd
Add
types-toml
package formypy
i can see the
github
workflow is failing at themypy
stage. i believe this is due tomypy
needing atypes-toml
package, not quite sure where i need to define this thoughChecklist
Update the documentation for the changes