New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend common_statements #160
Conversation
Pull Request Test Coverage Report for Build 1486867596
💛 - Coveralls |
Running
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, it's always lovely to see when developers follow the code style without any need to do any comment.
Your implementation looks wonderful, I just have some minor suggestions for you to evaluate
Regarding the The solution of the dependency break is to locate the packages in It's a lot of unrelated work for this PR, so it's fine if you leave it broken |
It looks like pydantic has a pin on They do not appear to have an open issue about this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for the contribution!
This PR is to close #159, adding support for users to write their own
common_statements
.Commits:
Checklist