Chore: RuboCop Style/MultipleComparison #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the single instance of the offense for MultipleComparison. It turned out that the code wasn't needed at all, since `Faraday::Utils.escape` already correctly stringifies booleans. I also added a unit test that seemed to be missing for this code.
Drenmi
force-pushed
the
chore/rubocop-multiple-comparison
branch
from
ef2f4fa
to
5292496
Compare
Drenmi
commented
Mar 4, 2019
Closed
iMacTia
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of RuboCop Quest.
This fixes the single instance of the offense for
MultipleComparison. It turned out that the code wasn't needed at all, sinceFaraday::Utils.escapealready correctly stringifies booleans.Additional Notes
I also added a unit test that seemed to be missing for this code.