Chore: RuboCop Style/MultipleComparison (#923)

.rubocop_todo.yml

@@ -47,8 +47,3 @@ Style/Documentation:
     - 'lib/faraday/response/logger.rb'
     - 'lib/faraday/response/raise_error.rb'
     - 'lib/faraday/utils.rb'
-
-# Offense count: 1
-Style/MultipleComparison:
-  Exclude:
-    - 'lib/faraday/encoders/flat_params_encoder.rb'

lib/faraday/encoders/flat_params_encoder.rb

@@ -29,7 +29,6 @@ def self.encode(params)
       buffer = +''
       params.each do |key, value|
         encoded_key = escape(key)
-        value = value.to_s if value == true || value == false
         if value.nil?
           buffer << "#{encoded_key}&"
         elsif value.is_a?(Array)

spec/faraday/params_encoders/flat_spec.rb

@@ -10,4 +10,20 @@
     expected = { 'a' => %w[one two three] }
     expect(subject.decode(query)).to eq(expected)
   end
+
+  it 'decodes boolean values' do
+    query = 'a=true&b=false'
+    expected = { 'a' => 'true', 'b' => 'false' }
+    expect(subject.decode(query)).to eq(expected)
+  end
+
+  it 'encodes boolean values' do
+    params = { a: true, b: false }
+    expect(subject.encode(params)).to eq('a=true&b=false')
+  end
+
+  it 'encodes boolean values in array' do
+    params = { a: [true, false] }
+    expect(subject.encode(params)).to eq('a=true&a=false')
+  end
 end

spec/faraday/params_encoders/nested_spec.rb

@@ -84,6 +84,16 @@
     expect(result).to eq(expected)
   end
 
+  it 'encodes boolean values' do
+    params = { a: true, b: false }
+    expect(subject.encode(params)).to eq('a=true&b=false')
+  end
+
+  it 'encodes boolean values in array' do
+    params = { a: [true, false] }
+    expect(subject.encode(params)).to eq('a%5B%5D=true&a%5B%5D=false')
+  end
+
   shared_examples 'a wrong decoding' do
     it do
       expect { subject.decode(query) }.to raise_error(TypeError) do |e|