Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoloading, dependency loading and middleware registry cleanup #1301

Merged
merged 2 commits into from Aug 9, 2021
Merged

Autoloading, dependency loading and middleware registry cleanup #1301

merged 2 commits into from Aug 9, 2021

Conversation

iMacTia
Copy link
Member

@iMacTia iMacTia commented Aug 8, 2021

Description

  • Remove autoloading
  • Remove adapters from list of dependencies, except for net_http (doesn't require ext libraries and it's good to have a default)
  • Remove dynamic dependency loader
  • Simplify MiddlewareRegistry

Todos

List any remaining work that needs to be done, i.e:

  • Tests
  • Upgrading
  • Documentation?

@olleolleolle olleolleolle changed the title Autoloading, dependency loading and middlewre registry cleanup Autoloading, dependency loading and middleware registry cleanup Aug 8, 2021
olleolleolle
olleolleolle reviewed Aug 8, 2021
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks grand!

I was curious if the middleware_mutex is still in use, now.

UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
faraday.gemspec Show resolved Hide resolved
lib/faraday.rb Show resolved Hide resolved
@iMacTia @olleolleolle
Apply suggestions from code review
4badf08 
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
@iMacTia
Copy link
Member Author

iMacTia commented Aug 8, 2021

Thanks for the quick review and the suggestions @olleolleolle 🙌!
Yes middleware_mutex is still used to ensure the middleware stack is thread-safe 👍

@iMacTia iMacTia mentioned this pull request Aug 8, 2021
Merged
2 tasks
@iMacTia iMacTia added this to Needs review in v2.0 Aug 8, 2021
olleolleolle
olleolleolle approved these changes Aug 9, 2021
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready!

v2.0 automation moved this from Needs review to Reviewer approved Aug 9, 2021
@iMacTia iMacTia merged commit 08b7d4d into main Aug 9, 2021
v2.0 automation moved this from Reviewer approved to Done Aug 9, 2021
@iMacTia iMacTia deleted the legacy-features-cleanup branch August 9, 2021 07:25
sgerrand pushed a commit to duffelhq/duffel-api-ruby that referenced this pull request Jan 5, 2022
Update Faraday middleware reference
9271a5a 
This class module was refactored and redesigned in lostisland/faraday#1301
timrogers pushed a commit to duffelhq/duffel-api-ruby that referenced this pull request Jan 9, 2022
Update Faraday middleware reference
13a2728 
This class module was refactored and redesigned in lostisland/faraday#1301
timrogers pushed a commit to duffelhq/duffel-api-ruby that referenced this pull request Jan 11, 2022
Update Faraday middleware reference
ce5a92e 
This class module was refactored and redesigned in lostisland/faraday#1301
timrogers pushed a commit to duffelhq/duffel-api-ruby that referenced this pull request Jan 11, 2022
Update Faraday middleware reference
3f1d942 
This class module was refactored and redesigned in lostisland/faraday#1301
@notEthan notEthan mentioned this pull request Jan 29, 2022
Closed
@iMacTia iMacTia mentioned this pull request Feb 2, 2022
Merged
@notEthan notEthan mentioned this pull request Feb 3, 2022
Merged
@winebarrel winebarrel mentioned this pull request Oct 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
v2.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iMacTia @olleolleolle