Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce the possibility to register middleware with symbols, strings or procs #1391

Merged
merged 2 commits into from Feb 2, 2022

Conversation

iMacTia
Copy link
Member

@iMacTia iMacTia commented Feb 2, 2022

Description

  • Reintroduce the possibility to register middleware with symbols, strings or procs
  • Update UPGRADING.md to explain the original removal from v2.0
  • Update CHANGELOG.md to point to the releases page

Fixes #1389

Additional notes

This was originally removed in #1301

Reintroduce the possibility to register middleware with symbols, strings or procs.

Fixes #1389
@olleolleolle olleolleolle force-pushed the fix/1389-register-middleware-with-proc branch from eaff9cc to 87016cd Compare February 2, 2022 19:03
This avoids leaking the class definition.
@olleolleolle olleolleolle force-pushed the fix/1389-register-middleware-with-proc branch from 87016cd to 3829c48 Compare February 2, 2022 19:20
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@olleolleolle olleolleolle merged commit 46f3b67 into main Feb 2, 2022
@olleolleolle olleolleolle deleted the fix/1389-register-middleware-with-proc branch February 2, 2022 19:24
@iMacTia
Copy link
Member Author

iMacTia commented Feb 2, 2022

Thank you so much for pushing this over the line @olleolleolle 🙏🎉!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

removal of proc mechanism for middleware
2 participants