Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.1x ci #1015

Closed
wants to merge 6 commits into from
Closed

0.1x ci #1015

wants to merge 6 commits into from

Conversation

technoweenie
Copy link
Member

@technoweenie technoweenie commented Sep 3, 2019

Backports our current CircleCI/CodeClimate config over from master. Hopefully we can then test and merge #1013.

@technoweenie
Copy link
Member Author

technoweenie commented Sep 3, 2019

Our test suite changes in master were never backported to this branch. Removing linting from the circle ci config was easy enough, but now the tests don't run.

bundle exec rspec --require rspec_junit_formatter --format progress --format RspecJunitFormatter --out ~/test-results/rspec/results.xml

bundler: command not found: rspec

I think we have a couple options:

  • Try to update this branch to run test/unit.
    • This doesn't seem trivial, since they were written to run on Travis, and not in a Docker image. Running rake test complains about the lack of lsof (used to check for the faraday test server thing).
  • Backport all of the test suite, circle ci, and rubocop changes to 0.1x
  • Release current master as v0.16.0 into the new stable branch 0.16.x. This could essentially be our v1.0 RC branch.

Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to CircleCI, there are variant Docker images, tagged with lots of suffixes.

https://circleci.com/docs/2.0/circleci-images/#ruby

Perhaps the ones we use could try the 2.6-stretch suffix, to make available lots of surrounding lsof etc?

Well, all of the image: keys in this branch's CircleCI configuration would have to be updated.


ruby26:
docker:
- image: circleci/ruby:2.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- image: circleci/ruby:2.6
- image: circleci/ruby:2.6-stretch

@systemist systemist mentioned this pull request Sep 22, 2019
@technoweenie
Copy link
Member Author

Closing in favor of just shipping v0.16.0 and a 0.16.x branch.

@technoweenie technoweenie deleted the 0.1x-ci branch September 27, 2019 16:30
@technoweenie technoweenie mentioned this pull request Oct 15, 2019
4 tasks
@BobbyMcWho
Copy link
Contributor

@technoweenie do you wanna un-delete this branch? I can copy/paste these changes, but would rather just cherry-pick

@technoweenie
Copy link
Member Author

This PR sets up Circle CI, which we've already transitioned from. So I don't think it's makes sense to bring this back.

@BobbyMcWho
Copy link
Contributor

Ah, I wasn't aware that the project was moving away from circleci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants