Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump eslint dependency #16

Merged
merged 2 commits into from Jun 25, 2020
Merged

deps: bump eslint dependency #16

merged 2 commits into from Jun 25, 2020

Conversation

smusali
Copy link
Contributor

@smusali smusali commented Jun 25, 2020

This version bump includes this change

@smusali smusali mentioned this pull request Jun 25, 2020
Merged
dm36
dm36 reviewed Jun 25, 2020
View reviewed changes
Copy link

@dm36 dm36 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like s100 is right that eslint should be a dev dependency- we should apply this to all other repos using eslint.

facebook/create-react-app#3209

@smusali
Copy link
Contributor Author

smusali commented Jun 25, 2020

Looks like s100 is right that eslint should be a dev dependency- we should apply this to all other repos using eslint.

facebook/create-react-app#3209

It does

@smusali smusali changed the title bump: update the package version to v1.3.2 deps: bump eslint dependency Jun 25, 2020
@smusali smusali requested a review from dm36 June 25, 2020 20:14
dm36
dm36 approved these changes Jun 25, 2020
View reviewed changes
Copy link

@dm36 dm36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@smusali smusali merged commit 53247be into master Jun 25, 2020
@smusali smusali deleted the v1.3.2 branch June 25, 2020 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dm36 dm36 dm36 approved these changes

@jakedipity jakedipity Awaiting requested review from jakedipity

@matt-march matt-march Awaiting requested review from matt-march

Assignees

@dm36 dm36

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smusali @dm36