Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: move eslint out of dependencies into devDependencies #20

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Conversation

smusali
Copy link
Contributor

@smusali smusali commented Jun 25, 2020

Summary

Similar to this, this package must stop using/including eslint in the building process.

Semver: patch

Copy link

@matt-march matt-march left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subsystem prefix on the commit should probably be deps: rather than bump:. Would also be nice to have the actual change (moving eslint to dev dependencies) in the title or body.

@smusali smusali changed the title bump: bump the package version to v2.3.2 deps: move eslint out of dependencies into devDependencies Jun 25, 2020
@smusali smusali requested a review from matt-march June 25, 2020 18:17
@smusali
Copy link
Contributor Author

smusali commented Jun 25, 2020

The subsystem prefix on the commit should probably be deps: rather than bump:. Would also be nice to have the actual change (moving eslint to dev dependencies) in the title or body.

Updated PR title and body

Copy link

@dm36 dm36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come eslint is 6.8.0 here but 6.5.1 in bunyan? https://github.com/logdna/logdna-bunyan/pull/15/files

@smusali smusali requested a review from dm36 June 25, 2020 20:14
@smusali
Copy link
Contributor Author

smusali commented Jun 25, 2020

how come eslint is 6.8.0 here but 6.5.1 in bunyan? https://github.com/logdna/logdna-bunyan/pull/15/files

Done!

Copy link

@dm36 dm36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@smusali smusali merged commit 468a439 into master Jun 25, 2020
@smusali smusali deleted the v2.3.2 branch June 25, 2020 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants