Add ability to use passed in Errors for callstacks and adjust how deeply you want to look for information #1269
Conversation
|
In e7ea403, deca3fb and b4e8a27, it is hard to identify and review the surgical changes. In the future, please try to separate the style/lint issues a commit by itself (probably the last commit) for a hastier merge. 🤗 I would need some time to review through, or if you could split/rebase them, it will be greatly appreciated! |
|
Sorry about that...It just sort of happens because I have prettier set up on save to make my life easier normally. |
|
Hi @ZachHaber, I merged your PR #1271 that addressed the prettier. You can rebase and do a force push to this same branch to update the commits for this PR. |
|
@peteriman, this branch is now rebased! Definitely a much smaller set of changes :) |
|
@peteriman, where did we land on this, along with the logfacesHTTP adapter checking only the first data value to see if it's an error? We could instead adjust this to loop through to find the first Error object instead, if we do that, I think it would make sense to surface that in the base LoggingEvent as |
|
@ZachHaber Hi there! My apologies that I haven't been available to take a look at this yet. But certainly, what you suggested sounds logical and great. Don't let me hold you back! |
|
I'll split that out into a separate branch/pr so we can decide on behavior afterwards more easily :) |
lamweili
force-pushed
the
master
branch
2 times, most recently
from
f14891e
to
8e7cc80
Compare
use the first data value if an Error to get callstack info. Only 1 line will be stripped from it by default Refs: log4js-node#1268
`logger.callStackLinesToSkip = 2` will make it skip 2 extra lines above the base. You can't skip negative lines Refs: log4js-node#1268
if set to an invalid value, it'll throw an error immediately, instead of later.
lamweili
force-pushed
the
master
branch
2 times, most recently
from
108458e
to
fccbab3
Compare
|
Rebased to be merged. |
closes #1268
New behavior:
logger.info(new Error())will parse the error instead of creating a new one.logger.callStackLinesToSkip = 1will look one level deeper than the base for Error values.logger.setParseCallStackFunction(undefined)will reset it to default (instead of throwing an error the next time it logs).logger.setParseCallStackFunction('')will throw an error immediately, rather than throw the next time you log.