refactor: remove duck typing

log4js-node · Sep 29, 2022 · 108458e · 108458e
1 parent 888e6bc
commit 108458e
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/lib/LoggingEvent.js b/lib/LoggingEvent.js
@@ -39,9 +39,8 @@ class LoggingEvent {
   serialise() {
     return flatted.stringify(this, (key, value) => {
       // JSON.stringify(new Error('test')) returns {}, which is not really useful for us.
-      // The following allows us to serialize errors correctly.
-      // duck-typing for Error object
-      if (value && value.message && value.stack) {
+      // The following allows us to serialize errors (semi) correctly.
+      if (value instanceof Error) {
         // eslint-disable-next-line prefer-object-spread
         value = Object.assign(
           { message: value.message, stack: value.stack },