Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TCP appender with Webpack and Typescript #1028

Merged
merged 2 commits into from Jan 18, 2022
Merged

Fix TCP appender with Webpack and Typescript #1028

merged 2 commits into from Jan 18, 2022

Conversation

techmunk
Copy link
Contributor

This is much like the fix for #1008 and #816
I've also included typescript typings for the TCP appender. I can remove these if you prefer.

There are some other core appenders that are also not in this list, however I'm unsure if this was intentional or by accident so have only included the one I'm currently concerned with and tested for now.

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@f8d46a9). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1028   +/-   ##
=========================================
  Coverage          ?   98.36%           
=========================================
  Files             ?       25           
  Lines             ?     1041           
  Branches          ?        0           
=========================================
  Hits              ?     1024           
  Misses            ?       17           
  Partials          ?        0           
Impacted Files Coverage Δ
lib/appenders/index.js 98.55% <100.00%> (ø)
lib/logger.js 97.82% <0.00%> (ø)
lib/appenders/adapters.js 94.44% <0.00%> (ø)
lib/appenders/fileSync.js 94.73% <0.00%> (ø)
lib/appenders/dateFile.js 100.00% <0.00%> (ø)
lib/appenders/tcp.js 91.30% <0.00%> (ø)
lib/appenders/stdout.js 100.00% <0.00%> (ø)
lib/appenders/logLevelFilter.js 100.00% <0.00%> (ø)
lib/levels.js 100.00% <0.00%> (ø)
lib/layouts.js 99.05% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8d46a9...4075ec5. Read the comment docs.

@guntram
Copy link

guntram commented Nov 9, 2021

Why was this not merged?

@swappler-sudo
Copy link

What's the status?

@lamweili lamweili added this to the 6.4.0 milestone Jan 18, 2022
@lamweili lamweili merged commit 653a20f into log4js-node:master Jan 18, 2022
@lamweili lamweili linked an issue Jan 20, 2022 that may be closed by this pull request
@lamweili
Copy link
Contributor

lamweili commented Jan 20, 2022

@swappler-sudo Fixed in log4js@6.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem using webpack with dateFile Appender
4 participants