Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem using webpack with dateFile Appender #1017

Closed
chenqf6 opened this issue May 24, 2020 · 5 comments · Fixed by #1028
Closed

Problem using webpack with dateFile Appender #1017

chenqf6 opened this issue May 24, 2020 · 5 comments · Fixed by #1028

Comments

@chenqf6
Copy link

chenqf6 commented May 24, 2020

The "path" argument must be of type string. Received type undefined" in log4js@5.2.2

@rnd-debug
Copy link
Contributor

@chenqf6 Looks similar to #1008 . Should be fixed in version 6.3.0 of log4js. Can you verify?

@techmunk
Copy link
Contributor

This is also happening with the tcp appender when using webpack, and I think would also happen with the other core appenders that are not listed there, such as tcp-server, recording, multiprocess, multifile.

I was trying to work around this by using import * as TCPAppender from 'log4js/lib/appenders/tcp' and then setting type to TCPAppender, but I'm also using typescript, so now typescript complains about their being no declaration file there and having an implicit any. I know I can work around the implicit any problem. It'd be really nice not to have to though.

@lamweili lamweili linked a pull request Jan 20, 2022 that will close this issue
@lamweili lamweili modified the milestones: 6.4.1, 6.4.0 Jan 20, 2022
@lamweili
Copy link
Contributor

lamweili commented Jan 20, 2022

@lamweili lamweili linked a pull request Jan 20, 2022 that will close this issue
@lamweili lamweili reopened this Jan 20, 2022
@lamweili
Copy link
Contributor

lamweili commented Jan 20, 2022

My apologies. I mixed up fileAppender with dateFileAppender and closed this issue wrongly.
Re-opening this issue.

@chenqf6 Can you do a check with log4js@6.4.0?

@lamweili lamweili removed this from the 6.4.0 milestone Jan 20, 2022
@lamweili
Copy link
Contributor

Closed due to extended period of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants