Do not start browser for skipped tests #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OndraM
force-pushed
the
bugfix/do-not-start-skipped
branch
2 times, most recently
from
5920b09
to
880db29
Compare
MortalFlesh
approved these changes
Nov 6, 2018
jirinovak
approved these changes
Nov 8, 2018
OndraM
force-pushed
the
bugfix/do-not-start-skipped
branch
from
880db29
to
b45dd9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154 .
This could be fixed thanks to sebastianbergmann/phpunit#3379 . It now depends on yet unreleased PHPUnit 7.4.4.
This will help to fail the tests faster - ie. you will know your test suite is broken sooner, as Steward will now not initialize empty browser window for those skipped tests.