Do not start browser for skipped tests (fixes #154)

CHANGELOG.md

@@ -17,6 +17,7 @@
 ### Fixed
 - Remote server running in W3C-protocol mode (eg. Selenium v3.5.3+) was erroneously detected as BrowserStack cloud service.
 - `--xdebug` option did not have any effect unless passed as the last option.
+- Do not start browser for test skipped because it was depending on some already failed test (using `@depends` annotation).
 
 ### Removed
 - `TestUtils` class which was already deprecated in 2.1.

composer.json

@@ -36,7 +36,7 @@
         "ext-filter": "*",
         "ext-SimpleXML": "*",
         "ext-libxml": "*",
-        "phpunit/phpunit": "^7.0",
+        "phpunit/phpunit": "7.4.x-dev",
         "symfony/console": "^4.0",
         "symfony/process": "^4.0 !=4.0.2",
         "symfony/finder": "^4.0",
@@ -55,7 +55,7 @@
         "ondram/ci-detector": "^3.0"
     },
     "require-dev": {
-        "php-mock/php-mock-phpunit": "^2.1.0",
+        "php-mock/php-mock-phpunit": "^2.1.2",
         "phpunit/php-code-coverage": "^6.0",
         "php-coveralls/php-coveralls": "^2.0",
         "symfony/var-dumper": "^4.0",

src-tests/Console/Command/Fixtures/SkippedTests/SkippedTest.php

@@ -0,0 +1,20 @@
+<?php declare(strict_types=1);
+
+namespace Lmc\Steward\Console\Command\Fixtures\SkippedTests;
+
+use Lmc\Steward\Test\AbstractTestCase;
+
+class SkippedTest extends AbstractTestCase
+{
+    public function testWhichFails(): void
+    {
+        $this->fail();
+    }
+
+    /**
+     * @depends testWhichFails
+     */
+    public function testsWhichShouldBeSkipped(): void
+    {
+    }
+}

src-tests/Console/Command/RunCommandIntegrationTest.php

@@ -158,4 +158,19 @@ public function testShouldExitWithCode0EvenWithFailedTestsWhenNoExitOptionIsPass
 
         $this->assertSame(0, $this->tester->getStatusCode());
     }
+
+    public function testShouldNotStartBrowserForSkippedTests(): void
+    {
+        $this->tester->execute(
+            [
+                'command' => $this->command->getName(),
+                'environment' => 'staging',
+                'browser' => 'chrome',
+                '--tests-dir' => __DIR__ . '/Fixtures/SkippedTests',
+            ],
+            ['verbosity' => OutputInterface::VERBOSITY_DEBUG]
+        );
+
+        $this->assertSame(1, mb_substr_count($this->tester->getDisplay(), 'Initializing "chrome" WebDriver'));
+    }
 }

src/Listener/WebDriverListener.php

@@ -16,6 +16,7 @@
 use PHPUnit\Framework\TestListener;
 use PHPUnit\Framework\TestListenerDefaultImplementation;
 use PHPUnit\Framework\WarningTestCase;
+use PHPUnit\Runner\BaseTestRunner;
 
 /**
  * Listener for initialization and destruction of WebDriver before and after each test.
@@ -60,6 +61,10 @@ public function startTest(Test $test): void
             throw new \InvalidArgumentException('Test case must be descendant of Lmc\Steward\Test\AbstractTestCase');
         }
 
+        if ($test->getStatus() === BaseTestRunner::STATUS_SKIPPED) {
+            return;
+        }
+
         // Initialize NullWebDriver if self::NO_BROWSER_ANNOTATION is used on testcase class or test method
         $testCaseAnnotations = AnnotationsParser::getAll(new \ReflectionClass($test));
         $testAnnotations = AnnotationsParser::getAll(new \ReflectionMethod($test, $test->getName(false)));