Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple of release issues #2956

Merged
merged 1 commit into from May 25, 2022
Merged

Fix a couple of release issues #2956

merged 1 commit into from May 25, 2022

Conversation

aomarks
Copy link
Member

@aomarks aomarks commented May 25, 2022

Found in #2954

@changeset-bot
Copy link

changeset-bot bot commented May 25, 2022

⚠️ No Changeset found

Latest commit: d7b41a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aomarks aomarks changed the title Fix release issues from https://github.com/lit/lit/pull/2954 Fix a couple of release issues May 25, 2022
@aomarks aomarks mentioned this pull request May 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2022

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -9% - +9% (-3.13ms - +3.08ms)
    this-change vs tip-of-tree

render

  • lit-element-list: unsure 🔍 -3% - +1% (-3.27ms - +0.98ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -5% - +2% (-2.36ms - +0.71ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -5% - +5% (-0.78ms - +0.71ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +2% (-1.80ms - +1.30ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -11% - +9% (-9.46ms - +7.50ms)
    this-change vs tip-of-tree

update

  • lit-element-list: unsure 🔍 -2% - +6% (-23.78ms - +56.57ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -6% - +7% (-6.61ms - +8.13ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -10% - +4% (-40.05ms - +17.80ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +3% (-1.75ms - +3.98ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -7% - +11% (-120.20ms - +181.81ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: unsure 🔍 -2% - +1% (-17.09ms - +5.46ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +1% (-23.12ms - +15.48ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
98.80ms - 100.68ms-unsure 🔍
-3% - +1%
-3.27ms - +0.98ms
faster ✔
22% - 24%
28.11ms - 32.12ms
tip-of-tree
tip-of-tree
98.98ms - 102.79msunsure 🔍
-1% - +3%
-0.98ms - +3.27ms
-faster ✔
21% - 24%
26.37ms - 31.57ms
previous-release
previous-release
128.09ms - 131.62msslower ❌
28% - 32%
28.11ms - 32.12ms
slower ❌
26% - 32%
26.37ms - 31.57ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1001.50ms - 1067.32ms-unsure 🔍
-2% - +6%
-23.78ms - +56.57ms
faster ✔
32% - 36%
489.47ms - 564.74ms
tip-of-tree
tip-of-tree
994.97ms - 1041.06msunsure 🔍
-5% - +2%
-56.57ms - +23.78ms
-faster ✔
33% - 36%
514.11ms - 572.89ms
previous-release
previous-release
1543.27ms - 1579.77msslower ❌
46% - 56%
489.47ms - 564.74ms
slower ❌
49% - 57%
514.11ms - 572.89ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
991.22ms - 1004.10ms-unsure 🔍
-2% - +1%
-17.09ms - +5.46ms
faster ✔
9% - 11%
94.71ms - 116.95ms
tip-of-tree
tip-of-tree
994.22ms - 1012.73msunsure 🔍
-1% - +2%
-5.46ms - +17.09ms
-faster ✔
8% - 10%
87.06ms - 112.96ms
previous-release
previous-release
1094.43ms - 1112.55msslower ❌
9% - 12%
94.71ms - 116.95ms
slower ❌
9% - 11%
87.06ms - 112.96ms
-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
43.22ms - 45.16ms-unsure 🔍
-5% - +2%
-2.36ms - +0.71ms
faster ✔
11% - 20%
5.49ms - 10.77ms
tip-of-tree
tip-of-tree
43.83ms - 46.21msunsure 🔍
-2% - +5%
-0.71ms - +2.36ms
-faster ✔
9% - 19%
4.58ms - 10.03ms
previous-release
previous-release
49.87ms - 54.78msslower ❌
12% - 25%
5.49ms - 10.77ms
slower ❌
10% - 22%
4.58ms - 10.03ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
112.88ms - 121.74ms-unsure 🔍
-6% - +7%
-6.61ms - +8.13ms
unsure 🔍
-8% - +6%
-9.85ms - +6.64ms
tip-of-tree
tip-of-tree
110.66ms - 122.45msunsure 🔍
-7% - +6%
-8.13ms - +6.61ms
-unsure 🔍
-10% - +6%
-11.48ms - +6.75ms
previous-release
previous-release
111.96ms - 125.87msunsure 🔍
-6% - +8%
-6.64ms - +9.85ms
unsure 🔍
-6% - +10%
-6.75ms - +11.48ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
33.44ms - 38.30ms-unsure 🔍
-9% - +9%
-3.13ms - +3.08ms
unsure 🔍
-15% - +1%
-5.82ms - +0.28ms
tip-of-tree
tip-of-tree
33.97ms - 37.83msunsure 🔍
-9% - +9%
-3.08ms - +3.13ms
-faster ✔
0% - 14%
0.07ms - 5.41ms
previous-release
previous-release
36.79ms - 40.48msunsure 🔍
-1% - +17%
-0.28ms - +5.82ms
unsure 🔍
-0% - +15%
+0.07ms - +5.41ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
13.49ms - 14.74ms-unsure 🔍
-5% - +5%
-0.78ms - +0.71ms
faster ✔
4% - 12%
0.54ms - 1.85ms
tip-of-tree
tip-of-tree
13.75ms - 14.56msunsure 🔍
-5% - +6%
-0.71ms - +0.78ms
-faster ✔
5% - 10%
0.71ms - 1.60ms
previous-release
previous-release
15.11ms - 15.51msslower ❌
3% - 13%
0.54ms - 1.85ms
slower ❌
5% - 12%
0.71ms - 1.60ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
377.60ms - 419.96ms-unsure 🔍
-10% - +4%
-40.05ms - +17.80ms
faster ✔
25% - 33%
135.52ms - 190.48ms
tip-of-tree
tip-of-tree
390.20ms - 429.60msunsure 🔍
-5% - +10%
-17.80ms - +40.05ms
-faster ✔
23% - 31%
125.52ms - 178.23ms
previous-release
previous-release
544.27ms - 579.29msslower ❌
32% - 50%
135.52ms - 190.48ms
slower ❌
29% - 45%
125.52ms - 178.23ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
67.50ms - 69.61ms-unsure 🔍
-3% - +2%
-1.80ms - +1.30ms
faster ✔
14% - 17%
11.21ms - 14.22ms
tip-of-tree
tip-of-tree
67.66ms - 69.94msunsure 🔍
-2% - +3%
-1.30ms - +1.80ms
-faster ✔
14% - 17%
10.90ms - 14.04ms
previous-release
previous-release
80.19ms - 82.35msslower ❌
16% - 21%
11.21ms - 14.22ms
slower ❌
16% - 21%
10.90ms - 14.04ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
146.83ms - 150.84ms-unsure 🔍
-1% - +3%
-1.75ms - +3.98ms
faster ✔
11% - 14%
18.43ms - 24.93ms
tip-of-tree
tip-of-tree
145.67ms - 149.77msunsure 🔍
-3% - +1%
-3.98ms - +1.75ms
-faster ✔
12% - 15%
19.52ms - 26.07ms
previous-release
previous-release
167.96ms - 173.07msslower ❌
12% - 17%
18.43ms - 24.93ms
slower ❌
13% - 18%
19.52ms - 26.07ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
74.96ms - 86.78ms-unsure 🔍
-11% - +9%
-9.46ms - +7.50ms
unsure 🔍
-12% - +9%
-9.91ms - +7.39ms
tip-of-tree
tip-of-tree
75.78ms - 87.93msunsure 🔍
-9% - +12%
-7.50ms - +9.46ms
-unsure 🔍
-11% - +10%
-9.04ms - +8.49ms
previous-release
previous-release
75.82ms - 88.44msunsure 🔍
-9% - +12%
-7.39ms - +9.91ms
unsure 🔍
-10% - +11%
-8.49ms - +9.04ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1595.00ms - 1804.80ms-unsure 🔍
-7% - +11%
-120.20ms - +181.81ms
unsure 🔍
-8% - +11%
-126.36ms - +177.87ms
tip-of-tree
tip-of-tree
1560.47ms - 1777.72msunsure 🔍
-11% - +7%
-181.81ms - +120.20ms
-unsure 🔍
-10% - +9%
-159.76ms - +149.65ms
previous-release
previous-release
1563.99ms - 1784.30msunsure 🔍
-10% - +7%
-177.87ms - +126.36ms
unsure 🔍
-9% - +10%
-149.65ms - +159.76ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1092.46ms - 1119.77ms-unsure 🔍
-2% - +1%
-23.12ms - +15.48ms
unsure 🔍
-3% - +1%
-29.57ms - +11.40ms
tip-of-tree
tip-of-tree
1096.29ms - 1123.58msunsure 🔍
-1% - +2%
-15.48ms - +23.12ms
-unsure 🔍
-2% - +1%
-25.75ms - +15.21ms
previous-release
previous-release
1099.93ms - 1130.47msunsure 🔍
-1% - +3%
-11.40ms - +29.57ms
unsure 🔍
-1% - +2%
-15.21ms - +25.75ms
-

tachometer-reporter-action v2 for Benchmarks

@aomarks aomarks merged commit b26313b into main May 25, 2022
@aomarks aomarks deleted the release branch May 25, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants