Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #2954

Merged
merged 1 commit into from May 25, 2022
Merged

Version Packages #2954

merged 1 commit into from May 25, 2022

Conversation

lit-robot
Copy link
Member

@lit-robot lit-robot commented May 25, 2022

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@lit-labs/router@0.1.0

Minor Changes

  • #2937 d2584ad6 - [BREAKING] Router properties prefixed with an underscore have been made
    private. These properties were being renamed in production builds and should not
    have been exposed as part of a public API.

@lit-labs/ssr@2.2.0

Minor Changes

  • #2940 ac356997 - Add option to defer hydration of top level custom elements.

lit@2.2.5

Patch Changes

  • #2952 a78cc3b7 - Fix SSR hydration bug relating to and other void elements having attribute bindings.

lit-html@2.2.5

Patch Changes

  • #2952 a78cc3b7 - Fix SSR hydration bug relating to and other void elements having attribute bindings.

@lit/lit-starter-js@1.0.4

Patch Changes

  • #2922 da9db86a - Update dependencies and remove unused dependencies

@lit/lit-starter-ts@1.0.4

Patch Changes

  • #2922 da9db86a - Update dependencies and remove unused dependencies

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2022

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -2% - +1% (-0.55ms - +0.17ms)
    this-change vs tip-of-tree

render

  • lit-element-list: unsure 🔍 -1% - +1% (-0.48ms - +0.89ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -1% - +2% (-0.21ms - +0.57ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -3% - +2% (-0.32ms - +0.22ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +1% (-0.82ms - +0.64ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -7% - +20% (-5.27ms - +15.71ms)
    this-change vs tip-of-tree

update

  • lit-element-list: unsure 🔍 -4% - +2% (-32.94ms - +12.75ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -2% - +3% (-1.89ms - +2.73ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -7% - +5% (-26.66ms - +18.85ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +2% (-1.72ms - +2.78ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -19% - +0% (-190.51ms - +8.80ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: unsure 🔍 -1% - +1% (-8.60ms - +5.64ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +2% (-18.91ms - +19.07ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
74.62ms - 75.67ms-unsure 🔍
-1% - +1%
-0.48ms - +0.89ms
faster ✔
18% - 19%
16.09ms - 18.03ms
tip-of-tree
tip-of-tree
74.50ms - 75.37msunsure 🔍
-1% - +1%
-0.89ms - +0.48ms
-faster ✔
18% - 20%
16.35ms - 18.19ms
previous-release
previous-release
91.40ms - 93.01msslower ❌
21% - 24%
16.09ms - 18.03ms
slower ❌
22% - 24%
16.35ms - 18.19ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
808.14ms - 818.01ms-unsure 🔍
-4% - +2%
-32.94ms - +12.75ms
faster ✔
36% - 37%
454.61ms - 478.18ms
tip-of-tree
tip-of-tree
800.87ms - 845.48msunsure 🔍
-2% - +4%
-12.75ms - +32.94ms
-faster ✔
34% - 37%
431.56ms - 481.04ms
previous-release
previous-release
1268.77ms - 1290.17msslower ❌
56% - 59%
454.61ms - 478.18ms
slower ❌
51% - 60%
431.56ms - 481.04ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
786.83ms - 795.13ms-unsure 🔍
-1% - +1%
-8.60ms - +5.64ms
faster ✔
9% - 11%
78.02ms - 95.24ms
tip-of-tree
tip-of-tree
786.67ms - 798.25msunsure 🔍
-1% - +1%
-5.64ms - +8.60ms
-faster ✔
9% - 11%
75.65ms - 94.66ms
previous-release
previous-release
870.07ms - 885.16msslower ❌
10% - 12%
78.02ms - 95.24ms
slower ❌
9% - 12%
75.65ms - 94.66ms
-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
29.74ms - 30.46ms-unsure 🔍
-1% - +2%
-0.21ms - +0.57ms
faster ✔
13% - 17%
4.36ms - 5.95ms
tip-of-tree
tip-of-tree
29.76ms - 30.08msunsure 🔍
-2% - +1%
-0.57ms - +0.21ms
-faster ✔
13% - 17%
4.61ms - 6.07ms
previous-release
previous-release
34.55ms - 35.97msslower ❌
14% - 20%
4.36ms - 5.95ms
slower ❌
15% - 20%
4.61ms - 6.07ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
80.37ms - 83.48ms-unsure 🔍
-2% - +3%
-1.89ms - +2.73ms
unsure 🔍
-7% - +0%
-6.02ms - +0.21ms
tip-of-tree
tip-of-tree
79.80ms - 83.22msunsure 🔍
-3% - +2%
-2.73ms - +1.89ms
-faster ✔
0% - 8%
0.13ms - 6.51ms
previous-release
previous-release
82.13ms - 87.53msunsure 🔍
-0% - +7%
-0.21ms - +6.02ms
slower ❌
0% - 8%
0.13ms - 6.51ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
26.38ms - 26.80ms-unsure 🔍
-2% - +1%
-0.55ms - +0.17ms
faster ✔
9% - 11%
2.73ms - 3.32ms
tip-of-tree
tip-of-tree
26.49ms - 27.07msunsure 🔍
-1% - +2%
-0.17ms - +0.55ms
-faster ✔
8% - 11%
2.48ms - 3.19ms
previous-release
previous-release
29.41ms - 29.81msslower ❌
10% - 13%
2.73ms - 3.32ms
slower ❌
9% - 12%
2.48ms - 3.19ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
10.94ms - 11.30ms-unsure 🔍
-3% - +2%
-0.32ms - +0.22ms
faster ✔
8% - 11%
1.00ms - 1.39ms
tip-of-tree
tip-of-tree
10.97ms - 11.37msunsure 🔍
-2% - +3%
-0.22ms - +0.32ms
-faster ✔
8% - 11%
0.94ms - 1.36ms
previous-release
previous-release
12.26ms - 12.38msslower ❌
9% - 13%
1.00ms - 1.39ms
slower ❌
8% - 12%
0.94ms - 1.36ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
340.95ms - 374.43ms-unsure 🔍
-7% - +5%
-26.66ms - +18.85ms
faster ✔
18% - 29%
77.69ms - 137.65ms
tip-of-tree
tip-of-tree
346.18ms - 377.02msunsure 🔍
-5% - +7%
-18.85ms - +26.66ms
-faster ✔
17% - 28%
74.50ms - 133.02ms
previous-release
previous-release
440.49ms - 490.23msslower ❌
21% - 39%
77.69ms - 137.65ms
slower ❌
20% - 37%
74.50ms - 133.02ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
54.55ms - 55.64ms-unsure 🔍
-1% - +1%
-0.82ms - +0.64ms
faster ✔
15% - 19%
9.90ms - 12.89ms
tip-of-tree
tip-of-tree
54.70ms - 55.66msunsure 🔍
-1% - +1%
-0.64ms - +0.82ms
-faster ✔
15% - 19%
9.84ms - 12.78ms
previous-release
previous-release
65.10ms - 67.88msslower ❌
18% - 23%
9.90ms - 12.89ms
slower ❌
18% - 23%
9.84ms - 12.78ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
123.59ms - 126.93ms-unsure 🔍
-1% - +2%
-1.72ms - +2.78ms
faster ✔
12% - 16%
17.60ms - 23.26ms
tip-of-tree
tip-of-tree
123.21ms - 126.23msunsure 🔍
-2% - +1%
-2.78ms - +1.72ms
-faster ✔
13% - 16%
18.23ms - 23.70ms
previous-release
previous-release
143.40ms - 147.97msslower ❌
14% - 19%
17.60ms - 23.26ms
slower ❌
14% - 19%
18.23ms - 23.70ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
76.39ms - 90.91ms-unsure 🔍
-7% - +20%
-5.27ms - +15.71ms
unsure 🔍
-5% - +23%
-3.32ms - +17.38ms
tip-of-tree
tip-of-tree
70.86ms - 86.00msunsure 🔍
-18% - +6%
-15.71ms - +5.27ms
-unsure 🔍
-12% - +16%
-8.76ms - +12.38ms
previous-release
previous-release
69.24ms - 84.00msunsure 🔍
-20% - +3%
-17.38ms - +3.32ms
unsure 🔍
-16% - +11%
-12.38ms - +8.76ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
846.70ms - 958.83ms-unsure 🔍
-19% - +0%
-190.51ms - +8.80ms
unsure 🔍
-17% - +2%
-168.86ms - +20.24ms
tip-of-tree
tip-of-tree
911.23ms - 1076.01msunsure 🔍
-1% - +21%
-8.80ms - +190.51ms
-unsure 🔍
-10% - +13%
-95.63ms - +128.72ms
previous-release
previous-release
900.95ms - 1053.21msunsure 🔍
-3% - +19%
-20.24ms - +168.86ms
unsure 🔍
-13% - +10%
-128.72ms - +95.63ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
858.53ms - 885.53ms-unsure 🔍
-2% - +2%
-18.91ms - +19.07ms
unsure 🔍
-2% - +2%
-15.81ms - +19.32ms
tip-of-tree
tip-of-tree
858.59ms - 885.30msunsure 🔍
-2% - +2%
-19.07ms - +18.91ms
-unsure 🔍
-2% - +2%
-15.78ms - +19.12ms
previous-release
previous-release
859.04ms - 881.51msunsure 🔍
-2% - +2%
-19.32ms - +15.81ms
unsure 🔍
-2% - +2%
-19.12ms - +15.78ms
-

tachometer-reporter-action v2 for Benchmarks

.changeset/modern-parrots-talk.md Outdated Show resolved Hide resolved
@@ -2,7 +2,7 @@
"private": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't have changesets for private packages that won't be published. Although we can manually fix the version when doing the first public publish.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

aomarks added a commit that referenced this pull request May 25, 2022
@aomarks
Copy link
Member

aomarks commented May 25, 2022

Addressed issues in #2956

aomarks added a commit that referenced this pull request May 25, 2022
Found in #2954

- Delete `@lit-labs/gen-wrapper-angular` changeset, because it's not released.
- Also bump `lit`, should have been included in #2952.
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aomarks aomarks merged commit 53160ac into main May 25, 2022
@aomarks aomarks deleted the changeset-release/main branch May 25, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants