New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lit-html] Expand documentation for TemplateResult
and render
.
#2849
Merged
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f9a1c99
Add `render` and `TemplateResult` documentation.
AndrewJakubowicz 49fb48e
Add changeset
AndrewJakubowicz e276e50
Add small amount of documentation to describe how to render a Templat…
AndrewJakubowicz 4f27638
Code review feedback
AndrewJakubowicz 69d7e2f
Merge branch 'main' of github.com:lit/lit into template-result-docs
AndrewJakubowicz 2717a5f
Code review feedback: add back variable into example. I think it's he…
AndrewJakubowicz 15de742
Code review feedback
AndrewJakubowicz eca93a8
Merge branch 'main' of github.com:lit/lit into template-result-docs
AndrewJakubowicz d5d58a9
Merge branch 'main' of github.com:lit/lit into template-result-docs
AndrewJakubowicz f154b90
Merge branch 'main' into template-result-docs
AndrewJakubowicz File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'lit-html': patch | ||
'lit': patch | ||
--- | ||
|
||
Expand documentation for `render` and `TemplateResult`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe to @justinfagnani 's point, this should say something like,
This example renders the text "Hello, Zoe!" inside a paragraph tag, appending it to the container
document.body
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Adding verbatim.